Update DivideByZeroUsingReturnValue.ql

ihsinme · web-flow · commit 065ca3c227d9 · 2023-02-06T19:42:46.000+03:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-369/DivideByZeroUsingReturnValue.ql b/cpp/ql/src/experimental/Security/CWE/CWE-369/DivideByZeroUsingReturnValue.ql
@@ -62,6 +62,7 @@ predicate mayBeReturnZero(Function fn) {
 }
 
 /** Gets the Guard which compares the expression `bound` */
+pragma[inline]
 GuardCondition checkByValue(Expr bound, Expr val) {
   exists(GuardCondition gc |
     (
@@ -122,8 +123,8 @@ pragma[inline]
 predicate checkConditions1(Expr div, Function fn, float changeInt) {
   exists(Expr val |
     (
-      val.getEnclosingFunction() = fn or
-      val.getEnclosingFunction() = div.getEnclosingFunction()
+      val.getEnclosingFunction() = fn //or
+      //val.getEnclosingFunction() = div.getEnclosingFunction()
     ) and
     val.getValue().toFloat() = changeInt and
     compareFunctionWithValue(div, fn, val)

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ predicate mayBeReturnZero(Function fn) {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	/** Gets the Guard which compares the expression `bound` */
	`65`	`+pragma[inline]`
`65`	`66`	`GuardCondition checkByValue(Expr bound, Expr val) {`
`66`	`67`	`exists(GuardCondition gc \|`
`67`	`68`	`(`
`@@ -122,8 +123,8 @@ pragma[inline]`
`122`	`123`	`predicate checkConditions1(Expr div, Function fn, float changeInt) {`
`123`	`124`	`exists(Expr val \|`
`124`	`125`	`(`
`125`		`- val.getEnclosingFunction() = fn or`
`126`		`- val.getEnclosingFunction() = div.getEnclosingFunction()`
	`126`	`+ val.getEnclosingFunction() = fn //or`
	`127`	`+ //val.getEnclosingFunction() = div.getEnclosingFunction()`
`127`	`128`	`) and`
`128`	`129`	`val.getValue().toFloat() = changeInt and`
`129`	`130`	`compareFunctionWithValue(div, fn, val)`