Apply suggestions from code review

tiferet · Stephan Brandauer · web-flow · commit 092e019de9b4 · 2022-11-15T10:48:32.000-08:00
Co-authored-by: Stephan Brandauer &lt;kaeluka@github.com&gt;
diff --git a/javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/extraction/ExtractEndpointDataTraining.qll b/javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/extraction/ExtractEndpointDataTraining.qll
@@ -22,7 +22,7 @@ import experimental.adaptivethreatmodeling.XssATM as XssAtm
  * `endpoint`. To preserve compatibility with the data pipeline, this relation will instead set
  * `featureValue` to the empty string in this case.
  */
-query predicate tokenFeatures(DataFlow::Node endpoint, string featureName, string featureValue) {
+predicate tokenFeatures(DataFlow::Node endpoint, string featureName, string featureValue) {
   trainingEndpoints(endpoint, _, _) and
   (
     EndpointFeatures::tokenFeatures(endpoint, featureName, featureValue)
@@ -209,7 +209,7 @@ DataFlow::Configuration getDataFlowCfg(Query query) {
 }
 
 // TODO: Delete this once we are no longer surfacing `hasFlowFromSource`.
-module FlowFromSource {
+private module FlowFromSource {
   predicate hasFlowFromSource(DataFlow::Node endpoint, Query q) {
     exists(Configuration cfg | cfg.getQuery() = q | cfg.hasFlow(_, endpoint))
   }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ import experimental.adaptivethreatmodeling.XssATM as XssAtm`
`22`	`22`	* `endpoint`. To preserve compatibility with the data pipeline, this relation will instead set
`23`	`23`	* `featureValue` to the empty string in this case.
`24`	`24`	`*/`
`25`		`-query predicate tokenFeatures(DataFlow::Node endpoint, string featureName, string featureValue) {`
	`25`	`+predicate tokenFeatures(DataFlow::Node endpoint, string featureName, string featureValue) {`
`26`	`26`	`trainingEndpoints(endpoint, _, _) and`
`27`	`27`	`(`
`28`	`28`	`EndpointFeatures::tokenFeatures(endpoint, featureName, featureValue)`
`@@ -209,7 +209,7 @@ DataFlow::Configuration getDataFlowCfg(Query query) {`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	// TODO: Delete this once we are no longer surfacing `hasFlowFromSource`.
`212`		`-module FlowFromSource {`
	`212`	`+private module FlowFromSource {`
`213`	`213`	`predicate hasFlowFromSource(DataFlow::Node endpoint, Query q) {`
`214`	`214`	`exists(Configuration cfg \| cfg.getQuery() = q \| cfg.hasFlow(_, endpoint))`
`215`	`215`	`}`