Swift: fix bad join order in WebView/JsExportedSource

d10c · d10c · commit 0e67100cadbf · 2022-11-03T15:30:04.000+01:00
The `getName = getName` join was happening too early,
before the methods themselves have been enumerated.
diff --git a/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll b/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll
@@ -118,7 +118,7 @@ private class JsExportedSource extends RemoteFlowSource {
       adopter.getEnclosingDecl() instanceof JsExportedType
     |
       this.(DataFlow::ParameterNode).getParameter().getDeclaringFunction() = adopter and
-      adopter.getName() = base.getName()
+      pragma[only_bind_out](adopter.getName()) = pragma[only_bind_out](base.getName())
     )
     or
     exists(FieldDecl adopter, FieldDecl base |

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ private class JsExportedSource extends RemoteFlowSource {`
`118`	`118`	`adopter.getEnclosingDecl() instanceof JsExportedType`
`119`	`119`	`\|`
`120`	`120`	`this.(DataFlow::ParameterNode).getParameter().getDeclaringFunction() = adopter and`
`121`		`- adopter.getName() = base.getName()`
	`121`	`+ pragma[only_bind_out](adopter.getName()) = pragma[only_bind_out](base.getName())`
`122`	`122`	`)`
`123`	`123`	`or`
`124`	`124`	`exists(FieldDecl adopter, FieldDecl base \|`