Java: add negative test cases for WebView file access query

egregius313 · egregius313 · commit 10875568ec8f · 2022-11-15T13:50:31.000-05:00
diff --git a/java/ql/test/query-tests/security/CWE-200/semmle/tests/WebViewFileAccess.java b/java/ql/test/query-tests/security/CWE-200/semmle/tests/WebViewFileAccess.java
@@ -11,4 +11,14 @@ void configure(WebView view) {
 
         settings.setAllowUniversalAccessFromFileURLs(true);
     }
+
+    void configureSafe(WebView view) {
+        WebSettings settings = view.getSettings();
+
+        settings.setAllowFileAccess(false);
+
+        settings.setAllowFileAccessFromFileURLs(false);
+
+        settings.setAllowUniversalAccessFromFileURLs(false);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,4 +11,14 @@ void configure(WebView view) {`
`11`	`11`
`12`	`12`	`settings.setAllowUniversalAccessFromFileURLs(true);`
`13`	`13`	`}`
	`14`	`+`
	`15`	`+ void configureSafe(WebView view) {`
	`16`	`+ WebSettings settings = view.getSettings();`
	`17`	`+`
	`18`	`+ settings.setAllowFileAccess(false);`
	`19`	`+`
	`20`	`+ settings.setAllowFileAccessFromFileURLs(false);`
	`21`	`+`
	`22`	`+ settings.setAllowUniversalAccessFromFileURLs(false);`
	`23`	`+ }`
`14`	`24`	`}`