Skip to content

Commit 1b29ed2

Browse files
committed
Ruby: Address review comments
1 parent 79a83ec commit 1b29ed2

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

ruby/ql/src/utils/modeleditor/ModelEditor.qll

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class Endpoint extends DataFlow::MethodNode {
6767
*/
6868
bindingset[this]
6969
string getParameterTypes() {
70-
// For now, return the names of postional parameters. We don't always have type information, so we can't return type names.
70+
// For now, return the names of postional and keyword parameters. We don't always have type information, so we can't return type names.
7171
// We don't yet handle splat params or block params.
7272
result =
7373
"(" +
@@ -98,10 +98,7 @@ class Endpoint extends DataFlow::MethodNode {
9898

9999
/** Holds if this API is a known neutral. */
100100
pragma[nomagic]
101-
predicate isNeutral() {
102-
none()
103-
// this instanceof FlowSummaryImpl::Public::NeutralCallable
104-
}
101+
predicate isNeutral() { none() }
105102

106103
/**
107104
* Holds if this API is supported by existing CodeQL libraries, that is, it is either a
@@ -161,7 +158,7 @@ class SourceCallable extends DataFlow::CallableNode {
161158
exists(string type, string path, string method |
162159
method = path.regexpCapture("(Method\\[[^\\]]+\\]).*", 1) and
163160
Util::pathToMethod(this, type, method) and
164-
sinkModel(type, path, _)
161+
sourceModel(type, path, _)
165162
)
166163
}
167164
}

0 commit comments

Comments
 (0)