C++: Drop the size return value of strlcat from hasTaintFlow

jketema · jketema · commit 1c878750494e · 2023-11-10T13:15:57.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/models/implementations/Strcat.qll b/cpp/ql/lib/semmle/code/cpp/models/implementations/Strcat.qll
@@ -124,7 +124,7 @@ class StrlcatFunction extends TaintFunction, ArrayFunction, SideEffectFunction {
       or
       input.isParameterDeref(1)
     ) and
-    (output.isParameterDeref(0) or output.isReturnValue())
+    output.isParameterDeref(0)
   }
 
   override predicate hasArrayInput(int param) {

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ class StrlcatFunction extends TaintFunction, ArrayFunction, SideEffectFunction {`
`124`	`124`	`or`
`125`	`125`	`input.isParameterDeref(1)`
`126`	`126`	`) and`
`127`		`- (output.isParameterDeref(0) or output.isReturnValue())`
	`127`	`+ output.isParameterDeref(0)`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`override predicate hasArrayInput(int param) {`