Skip to content

Commit 20f185e

Browse files
artem-smotrakovsmowton
authored andcommitted
Use tainted tag in JMS tests
1 parent 7158fd1 commit 20f185e

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

java/ql/test/library-tests/frameworks/jms/FlowTest.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ class TestConfig extends TaintTracking::Configuration {
1717
class JmsFlowTest extends InlineExpectationsTest {
1818
JmsFlowTest() { this = "JmsFlowTest" }
1919

20-
override string getARelevantTag() { result = "detected" }
20+
override string getARelevantTag() { result = "tainted" }
2121

2222
override predicate hasActualResult(Location location, string element, string tag, string value) {
23-
tag = "detected" and
23+
tag = "tainted" and
2424
exists(DataFlow::PathNode source, DataFlow::PathNode sink, TestConfig conf |
2525
conf.hasFlowPath(source, sink)
2626
|

java/ql/test/library-tests/frameworks/jms/MessageListenerImpl.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,27 @@ public void onMessage(Message message) { // $source
1818
if (message instanceof TextMessage) {
1919
TextMessage textMessage = (TextMessage) message;
2020
String text = textMessage.getText();
21-
sink(text); // $detected
21+
sink(text); // $tainted
2222
} else if (message instanceof BytesMessage) {
2323
BytesMessage bytesMessage = (BytesMessage) message;
2424
byte[] data = new byte[1024];
2525
bytesMessage.readBytes(data, 42);
26-
sink(new String(data)); // $detected
27-
sink(bytesMessage.readUTF()); // $detected
26+
sink(new String(data)); // $tainted
27+
sink(bytesMessage.readUTF()); // $tainted
2828
} else if (message instanceof MapMessage) {
2929
MapMessage mapMessage = (MapMessage) message;
30-
sink(mapMessage.getString("data")); // $detected
31-
sink(new String(mapMessage.getBytes("bytes"))); // $detected
30+
sink(mapMessage.getString("data")); // $tainted
31+
sink(new String(mapMessage.getBytes("bytes"))); // $tainted
3232
} else if (message instanceof ObjectMessage) {
3333
ObjectMessage objectMessage = (ObjectMessage) message;
34-
sink((String) objectMessage.getObject()); // $detected
34+
sink((String) objectMessage.getObject()); // $tainted
3535
} else if (message instanceof StreamMessage) {
3636
StreamMessage streamMessage = (StreamMessage) message;
3737
byte[] data = new byte[1024];
3838
streamMessage.readBytes(data);
39-
sink(new String(data)); // $detected
40-
sink(streamMessage.readString()); // $detected
41-
sink((String) streamMessage.readObject()); // $detected
39+
sink(new String(data)); // $tainted
40+
sink(streamMessage.readString()); // $tainted
41+
sink((String) streamMessage.readObject()); // $tainted
4242
}
4343
} catch (Exception e) {
4444
}
@@ -47,25 +47,25 @@ public void onMessage(Message message) { // $source
4747
public void readFromCounsumer(MessageConsumer consumer) throws Exception {
4848
TextMessage message = (TextMessage) consumer.receive(5000); // $source
4949
String text = message.getText();
50-
sink(text); // $detected
50+
sink(text); // $tainted
5151
message = (TextMessage) consumer.receive(); // $source
5252
text = message.getText();
53-
sink(text); // $detected
53+
sink(text); // $tainted
5454
message = (TextMessage) consumer.receiveNoWait(); // $source
5555
text = message.getText();
56-
sink(text); // $detected
56+
sink(text); // $tainted
5757
}
5858

5959
public void readFromQueueRequestor(QueueRequestor requestor, Message message) throws Exception {
6060
TextMessage reply = (TextMessage) requestor.request(message); // $source
6161
String text = reply.getText();
62-
sink(text); // $detected
62+
sink(text); // $tainted
6363
}
6464

6565
public void readFromTopicRequestor(TopicRequestor requestor, Message message) throws Exception {
6666
TextMessage reply = (TextMessage) requestor.request(message); // $source
6767
String text = reply.getText();
68-
sink(text); // $detected
68+
sink(text); // $tainted
6969
}
7070

7171
private void sink(String data) {

0 commit comments

Comments
 (0)