Ruby: actually call the isPublic() predicate I added

nickrolfe · nickrolfe · commit 20f76e50c3e2 · 2022-11-10T15:53:04.000Z
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/ActionCable.qll b/ruby/ql/lib/codeql/ruby/frameworks/ActionCable.qll
@@ -48,7 +48,7 @@ module ActionCable {
         // database
         not m = getActionCableChannelBase().asModule().getAnInstanceMethod() and
         // and as long as it's public
-        m.asCallableAstNode().isPublic() and
+        m.isPublic() and
         // and is not called `subscribed` or `unsubscribed`.
         not m.getMethodName() = ["subscribed", "unsubscribed"]
       |

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ module ActionCable {`
`48`	`48`	`// database`
`49`	`49`	`not m = getActionCableChannelBase().asModule().getAnInstanceMethod() and`
`50`	`50`	`// and as long as it's public`
`51`		`- m.asCallableAstNode().isPublic() and`
	`51`	`+ m.isPublic() and`
`52`	`52`	// and is not called `subscribed` or `unsubscribed`.
`53`	`53`	`not m.getMethodName() = ["subscribed", "unsubscribed"]`
`54`	`54`	`\|`