Skip to content

Commit 23f7f9a

Browse files
committed
fix some grammer mistakes, an unnecessary import, put blank like after go generate
1 parent 2f86c25 commit 23f7f9a

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

go/ql/lib/semmle/go/frameworks/Fasthttp.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ module Fasthttp {
3232
*/
3333
module Functions {
3434
/**
35-
* A function that don't sanitize user-provided file paths
35+
* A function that doesn't sanitize user-provided file paths
3636
*/
3737
class FileSystemAccess extends FileSystemAccess::Range, DataFlow::CallNode {
3838
FileSystemAccess() {
@@ -65,10 +65,11 @@ module Fasthttp {
6565
}
6666

6767
/**
68-
* A function that sends HTTP requests
68+
* A function that sends HTTP requests.
69+
*
6970
* Get* send a HTTP GET request.
7071
* Post send a HTTP POST request.
71-
* these Functions first arguments is a URL.
72+
* These functions first argument is a URL.
7273
*/
7374
class RequestForgerySink extends RequestForgery::Sink {
7475
RequestForgerySink() {

go/ql/src/experimental/CWE-918/SSRF.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ module ServerSideRequestForgery {
1515
private import semmle.go.security.UrlConcatenation
1616
private import semmle.go.dataflow.barrierguardutil.RegexpCheck
1717
private import semmle.go.dataflow.Properties
18-
private import semmle.go.frameworks.Fasthttp
1918

2019
/**
2120
* DEPRECATED: Use `Flow` instead.

go/ql/test/library-tests/semmle/go/frameworks/Fasthttp/fasthttp.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package main
22

3-
//go:generate depstubber -vendor "github.com/valyala/fasthttp" Args,Client,Cookie,FS,HostClient,LBClient,PathRewriteFunc,Request,RequestCtx,RequestHandler,RequestHeader,Response,ResponseHeader,Server,TCPDialer,URI,LBClient,PipelineClient AcquireURI,Serve,DialDualStack,Dial,DialTimeout,DialDualStackTimeout,Get,GetDeadline,GetTimeout,Post,Do,DoRedirects,AppendHTMLEscapeBytes,AppendHTMLEscape,AppendQuotedArg,ServeFileBytesUncompressed,ServeFileBytes,ServeFileUncompressed,ServeFile,SaveMultipartFile,DoTimeout,DoDeadline
3+
// go:generate depstubber -vendor "github.com/valyala/fasthttp" Args,Client,Cookie,FS,HostClient,LBClient,PathRewriteFunc,Request,RequestCtx,RequestHandler,RequestHeader,Response,ResponseHeader,Server,TCPDialer,URI,LBClient,PipelineClient AcquireURI,Serve,DialDualStack,Dial,DialTimeout,DialDualStackTimeout,Get,GetDeadline,GetTimeout,Post,Do,DoRedirects,AppendHTMLEscapeBytes,AppendHTMLEscape,AppendQuotedArg,ServeFileBytesUncompressed,ServeFileBytes,ServeFileUncompressed,ServeFile,SaveMultipartFile,DoTimeout,DoDeadline
4+
45
import (
56
"bufio"
67
"net"

0 commit comments

Comments
 (0)