Skip to content

Commit 307d2d5

Browse files
committed
Exclude .kt files from resource leak queries
1 parent acab8e8 commit 307d2d5

File tree

5 files changed

+3
-9
lines changed

5 files changed

+3
-9
lines changed

java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ predicate safeReaderType(RefType t) {
3333

3434
from ClassInstanceExpr cie, RefType t
3535
where
36+
cie.getFile().isJavaSourceFile() and
3637
badCloseableInit(cie) and
3738
cie.getType() = t and
3839
readerType(t) and

java/ql/src/Likely Bugs/Resource Leaks/CloseSql.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import CloseType
1515

1616
from CloseableInitExpr cie, RefType t
1717
where
18+
cie.getFile().isJavaSourceFile() and
1819
badCloseableInit(cie) and
1920
cie.getType() = t and
2021
sqlType(t) and

java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ predicate safeWriterType(RefType t) {
2929

3030
from ClassInstanceExpr cie, RefType t
3131
where
32+
cie.getFile().isJavaSourceFile() and
3233
badCloseableInit(cie) and
3334
cie.getType() = t and
3435
writerType(t) and
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
| CloseReader.kt:4:20:4:45 | new FileReader(...) | This FileReader is not always closed on method exit. |
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +0,0 @@
1-
| CloseWriter.kt:4:29:4:54 | new FileWriter(...) | This FileWriter is not always closed on method exit. |
2-
| CloseWriter.kt:9:20:9:45 | new FileWriter(...) | This FileWriter is not always closed on method exit. |
3-
| CloseWriter.kt:15:14:15:57 | new FileOutputStream(...) | This FileOutputStream is not always closed on method exit. |
4-
| CloseWriter.kt:20:5:20:48 | new FileOutputStream(...) | This FileOutputStream is not always closed on method exit. |
5-
| CloseWriter.kt:26:33:26:76 | new FileOutputStream(...) | This FileOutputStream is not always closed on method exit. |
6-
| CloseWriter.kt:31:24:31:67 | new FileOutputStream(...) | This FileOutputStream is not always closed on method exit. |
7-
| CloseWriter.kt:37:33:37:76 | new FileOutputStream(...) | This FileOutputStream is not always closed on method exit. |
8-
| CloseWriter.kt:42:24:42:67 | new FileOutputStream(...) | This FileOutputStream is not always closed on method exit. |

0 commit comments

Comments
 (0)