Skip to content

Commit 37a21ec

Browse files
committed
Java: Address review comments.
1 parent 74cdcab commit 37a21ec

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

java/ql/src/utils/modelgenerator/internal/CaptureSummaryFlowQuery.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,9 @@ string captureFlow(DataFlowTargetApi api) {
7373
}
7474

7575
/**
76-
* Gets the neutral summary for `api`, if any.
77-
* A neutral model is generated, if there does not exist any summary model.
76+
* Gets the neutral summary model for `api`, if any.
77+
* A neutral summary model is generated, if we are not generating
78+
* a summary model that applies to `api`.
7879
*/
7980
string captureNoFlow(DataFlowTargetApi api) {
8081
not exists(DataFlowTargetApi api0 | exists(captureFlow(api0)) and api0.lift() = api.lift()) and

java/ql/test/utils/modelgenerator/dataflow/p/MultipleImpl2.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
class MultipleImpl2 {
44

5+
// Multiple implementations of the same interface.
6+
// This is used to test that we only generate a summary model and
7+
// not neutral summary model for `IInterface.m`.
58
public interface IInterface {
69
Object m(Object value);
710
}

0 commit comments

Comments
 (0)