Skip to content

Commit 420008a

Browse files
committed
Swift: Minor corrections / clarifications.
1 parent cf7311f commit 420008a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

swift/ql/lib/codeql/swift/regex/Regex.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ class RegexRegexAdditionalFlowStep extends RegexAdditionalFlowStep {
140140
private predicate setsParseModeEdge(
141141
DataFlow::Node nodeFrom, DataFlow::Node nodeTo, RegexParseMode mode, boolean isSet
142142
) {
143-
// `Regex` methods that modify parse mode
143+
// `Regex` methods that modify the parse mode of an existing `Regex` object.
144144
exists(CallExpr ce |
145145
nodeFrom.asExpr() = ce.getQualifier() and
146146
nodeTo.asExpr() = ce and
@@ -166,11 +166,12 @@ class RegexRegexAdditionalFlowStep extends RegexAdditionalFlowStep {
166166
/**
167167
* An additional flow step for `NSRegularExpression`.
168168
*/
169-
class StandardRegexAdditionalFlowStep extends RegexAdditionalFlowStep {
169+
class NSRegularExpressionRegexAdditionalFlowStep extends RegexAdditionalFlowStep {
170170
override predicate step(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) { none() }
171171

172172
override predicate setsParseMode(DataFlow::Node node, RegexParseMode mode, boolean isSet) {
173-
// `NSRegularExpression.Options` values
173+
// `NSRegularExpression.Options` values (these are typically combined, then passed into
174+
// the `NSRegularExpression` initializer).
174175
node.asExpr()
175176
.(MemberRefExpr)
176177
.getMember()

0 commit comments

Comments
 (0)