Merge pull request github#15265 from github/redsun82/def-to-non-header-include-exceptions

C++: add `.def` to exceptions to AV rule 32

Author: redsun82

cpp/ql/src/change-notes/2024-01-09-add-exception-to-av-rule-32.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* The `cpp/include-non-header` style query will now ignore the `.def` extension for textual header inclusions.

cpp/ql/src/jsf/4.06 Pre-Processing Directives/AV Rule 32.ql

@@ -18,6 +18,7 @@ from Include i, File f, string extension
 where
   f = i.getIncludedFile() and
   extension = f.getExtension().toLowerCase() and
+  extension != "def" and
   extension != "inc" and
   extension != "inl" and
   extension != "tcc" and

cpp/ql/test/query-tests/jsf/4.06 Pre-Processing Directives/AV Rule 32/test.c

@@ -1,3 +1,4 @@
-#include "test.H"
-#include "test.xpm"
-#include "test2.c"
+#include "test.H"    // GOOD
+#include "test.xpm"  // GOOD
+#include "test2.c"   // BAD
+#include "test.def"  // GOOD