Apply suggestions from code review

jorgectf · aschackmull · web-flow · commit 50e95b5aadc5 · 2022-04-28T21:56:20.000+02:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/frameworks/MyBatis.qll b/java/ql/lib/semmle/code/java/frameworks/MyBatis.qll
@@ -134,8 +134,8 @@ private class MyBatisProviderStep extends TaintTracking::AdditionalValueStep {
   override predicate step(DataFlow::Node n1, DataFlow::Node n2) {
     exists(MethodAccess ma, Annotation a, Method providerMethod |
       exists(int i |
-        ma.getArgument(i) = n1.asExpr() and
-        providerMethod.getParameter(i) = n2.asParameter()
+        ma.getArgument(pragma[only_bind_into](i)) = n1.asExpr() and
+        providerMethod.getParameter(pragma[only_bind_into](i)) = n2.asParameter()
       )
     |
       a.getType() instanceof MyBatisProvider and

Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,8 @@ private class MyBatisProviderStep extends TaintTracking::AdditionalValueStep {`
`134`	`134`	`override predicate step(DataFlow::Node n1, DataFlow::Node n2) {`
`135`	`135`	`exists(MethodAccess ma, Annotation a, Method providerMethod \|`
`136`	`136`	`exists(int i \|`
`137`		`- ma.getArgument(i) = n1.asExpr() and`
`138`		`- providerMethod.getParameter(i) = n2.asParameter()`
	`137`	`+ ma.getArgument(pragma[only_bind_into](i)) = n1.asExpr() and`
	`138`	`+ providerMethod.getParameter(pragma[only_bind_into](i)) = n2.asParameter()`
`139`	`139`	`)`
`140`	`140`	`\|`
`141`	`141`	`a.getType() instanceof MyBatisProvider and`