Skip to content

Commit 52563b0

Browse files
committed
Factor logic out into interpretNeutral
1 parent 370a32d commit 52563b0

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,13 @@ private predicate interpretSummary(
529529
)
530530
}
531531

532+
private predicate interpretNeutral(UnboundCallable c, string kind, string provenance) {
533+
exists(string namespace, string type, string name, string signature |
534+
neutralModel(namespace, type, name, signature, kind, provenance) and
535+
c = interpretElement(namespace, type, false, name, signature, "")
536+
)
537+
}
538+
532539
// adapter class for converting Mad summaries to `SummarizedCallable`s
533540
private class SummarizedCallableAdapter extends SummarizedCallable {
534541
SummarizedCallableAdapter() { interpretSummary(this, _, _, _, _) }
@@ -568,12 +575,7 @@ private class NeutralCallableAdapter extends NeutralCallable {
568575
string kind;
569576
string provenance_;
570577

571-
NeutralCallableAdapter() {
572-
exists(string namespace, string type, string name, string signature |
573-
neutralModel(namespace, type, name, signature, kind, provenance_) and
574-
this = interpretElement(namespace, type, false, name, signature, "")
575-
)
576-
}
578+
NeutralCallableAdapter() { interpretNeutral(this, kind, provenance_) }
577579

578580
override string getKind() { result = kind }
579581

0 commit comments

Comments
 (0)