Skip to content

Commit 69ed00c

Browse files
committed
Ruby: QL4QL fix
1 parent f7cdd43 commit 69ed00c

File tree

1 file changed

+6
-3
lines changed
  • ruby/ql/lib/codeql/ruby/frameworks/actioncontroller

1 file changed

+6
-3
lines changed

ruby/ql/lib/codeql/ruby/frameworks/actioncontroller/Filters.qll

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,11 @@ module Filters {
188188
* with the same name is registered later one, overriding this one.
189189
*/
190190
predicate skipped(ActionControllerActionMethod action) {
191-
this = any(SkipFilter f).getSkippedFilter(action) or
192-
this.overridden()
191+
action = this.getAnAction() and
192+
(
193+
this = any(SkipFilter f).getSkippedFilter(action) or
194+
this.overridden()
195+
)
193196
}
194197

195198
/**
@@ -239,7 +242,7 @@ module Filters {
239242
}
240243

241244
/**
242-
* Behaviour that is common to filters and `skip_*` calls.
245+
* Behavior that is common to filters and `skip_*` calls.
243246
* This is separated just because when we don't want `Filter` to include `skip_*` calls.
244247
*/
245248
private class FilterImpl extends StringlikeLiteralCfgNode {

0 commit comments

Comments
 (0)