Skip to content

Commit 6eff72f

Browse files
committed
Include other map mutations
1 parent 4fc6f71 commit 6eff72f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/ql/lib/semmle/code/java/security/TaintedEnvironmentVariableQuery.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ private module ProcessBuilderEnvironmentConfig implements DataFlow::ConfigSig {
1313
)
1414
}
1515

16-
predicate isSink(DataFlow::Node sink) { sink.asExpr() = any(MapPutCall mpc).getQualifier() }
16+
predicate isSink(DataFlow::Node sink) { sink.asExpr() = any(MapMutation mm).getQualifier() }
1717
}
1818

1919
private module ProcessBuilderEnvironmentFlow = DataFlow::Global<ProcessBuilderEnvironmentConfig>;
@@ -28,8 +28,8 @@ module ExecTaintedEnvironmentConfig implements DataFlow::ConfigSig {
2828
sinkNode(sink, "environment-injection")
2929
or
3030
// sink is an added to a `ProcessBuilder::environment` map.
31-
exists(MapPutCall mpc | mpc.getAnArgument() = sink.asExpr() |
32-
ProcessBuilderEnvironmentFlow::flowToExpr(mpc.getQualifier())
31+
exists(MapMutation mm | mm.getAnArgument() = sink.asExpr() |
32+
ProcessBuilderEnvironmentFlow::flowToExpr(mm.getQualifier())
3333
)
3434
}
3535
}

0 commit comments

Comments
 (0)