Merge pull request github#11600 from geoffw0/offsetrangecheck

MathiasVP · web-flow · commit 7d5e215a931b · 2022-12-15T16:44:49.000Z
C++: Fix cpp/offset-use-before-range-check performance.
diff --git a/cpp/ql/src/Best Practices/Likely Errors/OffsetUseBeforeRangeCheck.ql b/cpp/ql/src/Best Practices/Likely Errors/OffsetUseBeforeRangeCheck.ql
@@ -15,6 +15,7 @@
 
 import cpp
 
+pragma[nomagic]
 predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {
   exists(LogicalAndExpr andexpr |
     access.getArrayOffset() = v.getAnAccess() and
@@ -23,6 +24,7 @@ predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {
   )
 }
 
+pragma[nomagic]
 predicate afterArrayAccess(Variable v, ArrayExpr access, Expr after) {
   exists(LogicalAndExpr andexpr |
     access.getArrayOffset() = v.getAnAccess() and

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`
`16`	`16`	`import cpp`
`17`	`17`
	`18`	`+pragma[nomagic]`
`18`	`19`	`predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {`
`19`	`20`	`exists(LogicalAndExpr andexpr \|`
`20`	`21`	`access.getArrayOffset() = v.getAnAccess() and`
`@@ -23,6 +24,7 @@ predicate beforeArrayAccess(Variable v, ArrayExpr access, Expr before) {`
`23`	`24`	`)`
`24`	`25`	`}`
`25`	`26`
	`27`	`+pragma[nomagic]`
`26`	`28`	`predicate afterArrayAccess(Variable v, ArrayExpr access, Expr after) {`
`27`	`29`	`exists(LogicalAndExpr andexpr \|`
`28`	`30`	`access.getArrayOffset() = v.getAnAccess() and`