Skip to content

Commit 806dacb

Browse files
authored
Merge pull request github#8989 from erik-krogh/mentionAll
JS/RB: have `ApiGraphModelsSpecific.qll` mention all the required predicates
2 parents 5c57490 + f87312d commit 806dacb

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,18 @@
44
* It must export the following members:
55
* ```ql
66
* class Unit // a unit type
7+
* module AccessPathSyntax // a re-export of the AccessPathSyntax module
8+
* class InvokeNode // a type representing an invocation connected to the API graph
79
* module API // the API graph module
810
* predicate isPackageUsed(string package)
911
* API::Node getExtraNodeFromPath(string package, string type, string path, int n)
1012
* API::Node getExtraSuccessorFromNode(API::Node node, AccessPathToken token)
11-
* API::Node getExtraSuccessorFromInvoke(API::InvokeNode node, AccessPathToken token)
12-
* predicate invocationMatchesExtraCallSiteFilter(API::InvokeNode invoke, AccessPathToken token)
13+
* API::Node getExtraSuccessorFromInvoke(InvokeNode node, AccessPathToken token)
14+
* predicate invocationMatchesExtraCallSiteFilter(InvokeNode invoke, AccessPathToken token)
15+
* InvokeNode getAnInvocationOf(API::Node node)
16+
* predicate isExtraValidTokenNameInIdentifyingAccessPath(string name)
17+
* predicate isExtraValidNoArgumentTokenInIdentifyingAccessPath(string name)
18+
* predicate isExtraValidTokenArgumentInIdentifyingAccessPath(string name, string argument)
1319
* ```
1420
*/
1521

ruby/ql/lib/codeql/ruby/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* It must export the following members:
55
* ```ql
66
* class Unit // a unit type
7+
* module AccessPathSyntax // a re-export of the AccessPathSyntax module
78
* class InvokeNode // a type representing an invocation connected to the API graph
89
* module API // the API graph module
910
* predicate isPackageUsed(string package)
@@ -12,6 +13,9 @@
1213
* API::Node getExtraSuccessorFromInvoke(InvokeNode node, AccessPathToken token)
1314
* predicate invocationMatchesExtraCallSiteFilter(InvokeNode invoke, AccessPathToken token)
1415
* InvokeNode getAnInvocationOf(API::Node node)
16+
* predicate isExtraValidTokenNameInIdentifyingAccessPath(string name)
17+
* predicate isExtraValidNoArgumentTokenInIdentifyingAccessPath(string name)
18+
* predicate isExtraValidTokenArgumentInIdentifyingAccessPath(string name, string argument)
1519
* ```
1620
*/
1721

0 commit comments

Comments
 (0)