Skip to content

Commit 844b6e0

Browse files
author
Alvaro Muñoz
committed
Bump qlpack versions
1 parent 842b741 commit 844b6e0

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

ql/lib/codeql/actions/ast/internal/Ast.qll

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -818,8 +818,9 @@ class JobImpl extends AstNodeImpl, TJobNode {
818818
}
819819

820820
private predicate hasPrivilegedTrigger() {
821-
// the Job is triggered by an event other than `pull_request`
821+
// the Job is triggered by an event other than `pull_request`, `push`, or `workflow_call`
822822
count(this.getATriggerEvent()) = 1 and
823+
not this.getATriggerEvent().getName() = "push" and
823824
not this.getATriggerEvent().getName() = "pull_request" and
824825
not this.getATriggerEvent().getName() = "workflow_call"
825826
or
@@ -832,8 +833,11 @@ class JobImpl extends AstNodeImpl, TJobNode {
832833
not exists(this.getEnclosingWorkflow().(ReusableWorkflowImpl).getACaller())
833834
)
834835
or
835-
// the Workflow has multiple triggers so at least one is not "pull_request"
836-
count(this.getATriggerEvent()) > 1
836+
// the Job is triggered by an event other than `push`, `pull_request`, or `workflow_call`
837+
exists(string event |
838+
this.getATriggerEvent().getName() = event and
839+
not event = ["push", "pull_request", "workflow_call"]
840+
)
837841
}
838842

839843
/** Gets the trigger event that starts this workflow. */

ql/lib/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
library: true
33
warnOnImplicitThis: true
44
name: githubsecuritylab/actions-all
5-
version: 0.0.31
5+
version: 0.0.32
66
dependencies:
77
codeql/util: ^0.2.0
88
codeql/yaml: ^0.1.2

ql/src/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
library: false
33
name: githubsecuritylab/actions-queries
4-
version: 0.0.31
4+
version: 0.0.32
55
groups:
66
- actions
77
- queries

ql/test/query-tests/Security/CWE-829/UntrustedCheckoutCritical.expected

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
| .github/workflows/auto_ci.yml:20:9:27:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
22
| .github/workflows/auto_ci.yml:67:9:74:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
3-
| .github/workflows/dependabot1.yml:15:9:19:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
4-
| .github/workflows/dependabot1.yml:39:9:43:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
53
| .github/workflows/gitcheckout.yml:10:11:18:8 | Run Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
64
| .github/workflows/level0.yml:99:9:103:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
75
| .github/workflows/level0.yml:125:9:129:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
| .github/workflows/dependabot1.yml:15:9:19:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |
2+
| .github/workflows/dependabot1.yml:39:9:43:6 | Uses Step | Potential unsafe checkout of untrusted pull request on privileged workflow. |

0 commit comments

Comments
 (0)