Skip to content

Commit 9880952

Browse files
hvitvedhmac
authored andcommitted
Revert "Ruby: Fix performance of Filter.getAnAction"
This reverts commit f6c863c.
1 parent 710ddb1 commit 9880952

File tree

1 file changed

+5
-6
lines changed
  • ruby/ql/lib/codeql/ruby/frameworks/actioncontroller

1 file changed

+5
-6
lines changed

ruby/ql/lib/codeql/ruby/frameworks/actioncontroller/Filters.qll

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,13 @@ module Filters {
6565
not exists(this.getOnlyArgument()) and
6666
forall(string except | except = this.getExceptArgument() | result.getName() != except)
6767
) and
68-
// This is a simple heuristic and will miss some cases.
6968
(
70-
// The action is in the same class as this call
71-
result = lookupMethod(this.getExpr().getEnclosingModule().getModule(), _)
69+
result = this.getExpr().getEnclosingModule().getAMethod()
7270
or
73-
// or the action is in an immediate subclass of this call
74-
result.getEnclosingModule().getModule().getAnImmediateAncestor() =
75-
this.getExpr().getEnclosingModule().getModule()
71+
exists(ModuleBase m |
72+
m.getModule() = this.getExpr().getEnclosingModule().getModule().getADescendent() and
73+
result = m.getAMethod()
74+
)
7675
)
7776
}
7877

0 commit comments

Comments
 (0)