Skip to content

Commit 9f722a7

Browse files
committed
Disable java_and_kotlin inconsistency test; accept changes
This was testing that a signature inconsistency occurs, but this now manifests as a db inconsistency which can't be used as a test expectation because specific tuple numbers are liable to change with the environment.
1 parent f2fded6 commit 9f722a7

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

java/ql/test/kotlin/library-tests/java_and_kotlin/Java.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,12 @@ public String fn0(int x) {
1111
return super.fn0(x);
1212
}
1313

14+
/*
15+
// Java interop disabled as it currently doesn't work (no symbol fn1(int, Completion<...>) gets created)
1416
@Override
1517
public Object fn1(int x, Continuation<? super String> $completion) {
1618
return super.fn1(x, $completion);
1719
}
20+
*/
1821
}
1922
}

java/ql/test/kotlin/library-tests/java_and_kotlin/Kotlin.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,3 @@ class Dkotlin : Base() {
1313
override fun fn0(x: Int): String = super.fn0(x)
1414
override suspend fun fn1(x: Int): String = super.fn1(x)
1515
}
16-
17-
// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.NotNull
18-
// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.Nullable
19-
// Diagnostic Matches: Unknown location for org.jetbrains.annotations.NotNull
20-
// Diagnostic Matches: Unknown location for org.jetbrains.annotations.Nullable
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
11
methods
22
| Java.java:4:7:4:13 | javaFun | javaFun() |
33
| Java.java:10:17:10:19 | fn0 | fn0(int) |
4-
| Java.java:15:17:15:19 | fn1 | fn1(int,kotlin.coroutines.Continuation) |
54
| Kotlin.kt:2:2:4:2 | kotlinFun | kotlinFun() |
65
| Kotlin.kt:8:10:8:38 | fn0 | fn0(int) |
76
| Kotlin.kt:9:18:9:46 | fn1 | fn1(int) |
87
| Kotlin.kt:13:14:13:51 | fn0 | fn0(int) |
98
| Kotlin.kt:14:22:14:59 | fn1 | fn1(int) |
109
overrides
1110
| Java.java:10:17:10:19 | fn0 | Kotlin.kt:8:10:8:38 | fn0 |
12-
| Java.java:15:17:15:19 | fn1 | java_and_kotlin.testproj/test.class.files/Base.class:0:0:0:0 | fn1 |
1311
| Kotlin.kt:13:14:13:51 | fn0 | Kotlin.kt:8:10:8:38 | fn0 |
1412
| Kotlin.kt:14:22:14:59 | fn1 | Kotlin.kt:9:18:9:46 | fn1 |
1513
signature_mismatch
1614
| Kotlin.kt:9:18:9:46 | fn1 | fn1(int) |
17-
| java_and_kotlin.testproj/test.class.files/Base.class:0:0:0:0 | fn1 | fn1(int,kotlin.coroutines.Continuation) |
1815
#select
1916
| Java.java:5:3:5:26 | kotlinFun(...) | Kotlin.kt:2:2:4:2 | kotlinFun |
2017
| Java.java:11:11:11:22 | fn0(...) | Kotlin.kt:8:10:8:38 | fn0 |
21-
| Java.java:16:11:16:35 | fn1(...) | java_and_kotlin.testproj/test.class.files/Base.class:0:0:0:0 | fn1 |
2218
| Kotlin.kt:13:40:13:51 | fn0(...) | Kotlin.kt:8:10:8:38 | fn0 |
2319
| Kotlin.kt:14:48:14:59 | fn1(...) | Kotlin.kt:9:18:9:46 | fn1 |

0 commit comments

Comments
 (0)