Skip to content

Commit a10b45e

Browse files
authored
Merge pull request github#11927 from mvogelgesang/express-rate-limit
JS: Updated express-rate-limit example to match implementation examples f…
2 parents 05ecd2e + a3ff072 commit a10b45e

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

javascript/ql/src/Security/CWE-770/examples/MissingRateLimitingGood.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var app = express();
33

44
// set up rate limiter: maximum of five requests per minute
55
var RateLimit = require('express-rate-limit');
6-
var limiter = new RateLimit({
6+
var limiter = RateLimit({
77
windowMs: 1*60*1000, // 1 minute
88
max: 5
99
});
Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
1-
var express = require('express');
1+
var express = require("express");
22
var app = express();
33

44
// set up rate limiter: maximum of five requests per minute
5-
var RateLimit = require('express-rate-limit');
6-
var limiter = new RateLimit({
7-
windowMs: 1*60*1000, // 1 minute
8-
max: 5
5+
var RateLimit = require("express-rate-limit");
6+
var limiter = RateLimit({
7+
windowMs: 1 * 60 * 1000, // 1 minute
8+
max: 5,
99
});
1010

1111
// apply rate limiter to all requests
1212
app.use(limiter);
1313

14-
app.get('/:path', function(req, res) {
14+
app.get("/:path", function (req, res) {
1515
let path = req.params.path;
16-
if (isValidPath(path))
17-
res.sendFile(path);
16+
if (isValidPath(path)) res.sendFile(path);
1817
});

0 commit comments

Comments
 (0)