Apply suggestions from code review

Alvaro Muñoz · web-flow · commit aa37339deb22 · 2024-03-14T09:22:40.000+01:00
diff --git a/ql/lib/codeql/actions/Ast.qll b/ql/lib/codeql/actions/Ast.qll
@@ -5,7 +5,6 @@ module Utils {
   bindingset[expr]
   string normalizeExpr(string expr) {
     result =
-      //[A-Za-z0-9'\"_\\[\\]\\*\\(\\)\\.\\-]
       expr.regexpReplaceAll("\\['([a-zA-Z0-9_\\*\\-]+)'\\]", ".$1")
           .regexpReplaceAll("\\[\"([a-zA-Z0-9_\\*\\-]+)\"\\]", ".$1")
           .regexpReplaceAll("\\s*\\.\\s*", ".")
diff --git a/ql/lib/codeql/actions/ast/internal/Ast.qll b/ql/lib/codeql/actions/ast/internal/Ast.qll
@@ -47,7 +47,7 @@ private newtype TAstNode =
       )
     )
     or
-    // if's conditions do not need to be delimted with ${{}}
+    // `if`'s conditions do not need to be delimted with ${{}}
     exists(YamlMapping m |
       m.maps(key, value) and
       key.(YamlScalar).getValue() = ["if"] and

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ private newtype TAstNode =`
`47`	`47`	`)`
`48`	`48`	`)`
`49`	`49`	`or`
`50`		`- // if's conditions do not need to be delimted with ${{}}`
	`50`	+ // `if`'s conditions do not need to be delimted with ${{}}
`51`	`51`	`exists(YamlMapping m \|`
`52`	`52`	`m.maps(key, value) and`
`53`	`53`	`key.(YamlScalar).getValue() = ["if"] and`