Skip to content

Commit abe6f16

Browse files
committed
Python: Add example of models subclassing problem
In reality, we only want to model this as a `rest_framework.response.Response`, since our .qll modeling is more precise for rest-framework responses than if we also modeled it as a basic django http response. (specifically, that default mime-type handling is way different).
1 parent 5c89c38 commit abe6f16

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

python/ql/test/experimental/library-tests/FindSubclass/Find.expected

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
| Django.Views.View~Subclass | find_subclass_test | Member[clash2] |
22
| Django.Views.View~Subclass | find_subclass_test | Member[clash3] |
33
| Django.Views.View~Subclass | find_subclass_test | Member[clash] |
4+
| django.http.response.HttpResponse~Subclass | find_subclass_test | Member[MyRestResponse] |
45
| flask.MethodView~Subclass | find_subclass_test | Member[C] |
56
| flask.View~Subclass | find_subclass_test | Member[A] |
67
| flask.View~Subclass | find_subclass_test | Member[B] |
@@ -14,3 +15,4 @@
1415
| flask.View~Subclass | find_subclass_test | Member[clash] |
1516
| flask.View~Subclass | find_subclass_test | Member[complete_module_alias] |
1617
| flask.View~Subclass | find_subclass_test | Member[complete_module_alias_no_use] |
18+
| rest_framework.response.Response~Subclass | find_subclass_test | Member[MyRestResponse] |

python/ql/test/experimental/library-tests/FindSubclass/find_subclass_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,7 @@ class C(flask.views.MethodView):
5151

5252
def wrapper():
5353
return View # $ MISSING
54+
55+
import rest_framework
56+
class MyRestResponse(rest_framework.response.Response):
57+
pass

0 commit comments

Comments
 (0)