Swift: Add hasQualifiedName methods and tests.

Author: geoffw0

swift/ql/lib/codeql/swift/elements/decl/MethodDecl.qll

@@ -21,4 +21,33 @@ class MethodDecl extends AbstractFunctionDecl {
     or
     this = getAMember(any(ProtocolDecl c))
   }
+
+  /**
+   * Holds if this function is called `funcName` and its a member of a
+   * class, struct, extension, enum or protocol call `typeName`.
+   */
+  predicate hasQualifiedName(string typeName, string funcName) {
+    this.getName() = funcName and
+    (
+      exists(NominalTypeDecl c |
+        c.getFullName() = typeName and
+        c.getAMember() = this
+      )
+      or
+      exists(ExtensionDecl e |
+        e.getExtendedTypeDecl().getFullName() = typeName and
+        e.getAMember() = this
+      )
+    )
+  }
+
+  /**
+   * Holds if this function is called `funcName` and its a member of a
+   * class, struct, extension, enum or protocol call `typeName` in a moduile
+   * called `moduleName`.
+   */
+  predicate hasQualifiedName(string moduleName, string typeName, string funcName) {
+    this.hasQualifiedName(typeName, funcName) and
+    this.getModule().getFullName() = moduleName
+  }
 }

swift/ql/test/library-tests/elements/decl/abstractfunctiondecl/abstractfunctiondecl.expected

@@ -0,0 +1,8 @@
+| abstractfunctiondecl.swift:2:1:2:15 | func1() | getName:func1() |
+| abstractfunctiondecl.swift:5:2:5:16 | func2() | MethodDecl, getName:func2(), hasQualifiedName(2):Class1.func2(), hasQualifiedName(3):abstractfunctiondecl.Class1.func2() |
+| abstractfunctiondecl.swift:8:3:8:17 | func3() | MethodDecl, getName:func3(), hasQualifiedName(2):Class1.Class2.func3(), hasQualifiedName(3):abstractfunctiondecl.Class1.Class2.func3() |
+| abstractfunctiondecl.swift:13:2:13:13 | func4() | MethodDecl, getName:func4(), hasQualifiedName(2):Protocol1.func4(), hasQualifiedName(3):abstractfunctiondecl.Protocol1.func4() |
+| abstractfunctiondecl.swift:17:2:17:16 | func4() | MethodDecl, getName:func4(), hasQualifiedName(2):Class3.func4(), hasQualifiedName(3):abstractfunctiondecl.Class3.func4() |
+| abstractfunctiondecl.swift:21:2:21:16 | func5() | MethodDecl, getName:func5(), hasQualifiedName(2):Class3.func5(), hasQualifiedName(3):abstractfunctiondecl.Class3.func5() |
+| abstractfunctiondecl.swift:25:2:25:16 | func6() | MethodDecl, getName:func6(), hasQualifiedName(2):Struct1.func6(), hasQualifiedName(3):abstractfunctiondecl.Struct1.func6() |
+| abstractfunctiondecl.swift:31:2:31:16 | func7() | MethodDecl, getName:func7(), hasQualifiedName(2):Enum1.func7(), hasQualifiedName(3):abstractfunctiondecl.Enum1.func7() |

swift/ql/test/library-tests/elements/decl/abstractfunctiondecl/abstractfunctiondecl.ql

@@ -0,0 +1,25 @@
+import swift
+
+string describe(AbstractFunctionDecl f) {
+  result = "getName:" + f.getName()
+  or
+  (
+    result = "MethodDecl" and f instanceof MethodDecl
+  )
+  or
+  exists(string a, string b |
+    f.(MethodDecl).hasQualifiedName(a, b) and
+    result = "hasQualifiedName(2):" + a + "." + b
+  )
+  or
+  exists(string a, string b, string c |
+    f.(MethodDecl).hasQualifiedName(a, b, c) and
+    result = "hasQualifiedName(3):" + a + "." + b + "." + c
+  )
+}
+
+from AbstractFunctionDecl f
+where
+  not f.getFile() instanceof UnknownFile and
+  not f.getName().matches("%init%")
+select f, concat(describe(f), ", ")

swift/ql/test/library-tests/elements/decl/abstractfunctiondecl/abstractfunctiondecl.swift

@@ -0,0 +1,32 @@
+
+func func1() {}
+
+class Class1 {
+	func func2() {}
+
+	class Class2 {
+		func func3() {}
+	}
+}
+
+protocol Protocol1 {
+	func func4()
+}
+
+class Class3: Class1, Protocol1 {
+	func func4() {}
+}
+
+extension Class3 {
+	func func5() {}
+}
+
+struct Struct1 {
+	func func6() {}
+}
+
+enum Enum1 {
+	case case1
+	case case2
+	func func7() {}
+}