SubclassFinder: don't include site-packages

RasmusWL · RasmusWL · commit b24e56512804 · 2023-12-08T11:27:53.000+01:00
diff --git a/python/ql/lib/semmle/python/frameworks/internal/SubclassFinder.qll b/python/ql/lib/semmle/python/frameworks/internal/SubclassFinder.qll
@@ -112,12 +112,8 @@ module NotExposed {
   }
 
   predicate isAllowedModule(Module mod) {
-    // for now, we only want to model things in site-packages (since we know these are
-    // libraries used by real code)
-    mod.getFile().getAbsolutePath().matches("%/site-packages/%")
-    or
-    // for CI testing
-    mod.getFile().getRelativePath().matches("%/find_subclass_test.py")
+    // don't include anything found in site-packages
+    exists(mod.getFile().getRelativePath())
   }
 
   predicate isTestCode(AstNode ast) {

Original file line number	Diff line number	Diff line change
`@@ -112,12 +112,8 @@ module NotExposed {`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`predicate isAllowedModule(Module mod) {`
`115`		`- // for now, we only want to model things in site-packages (since we know these are`
`116`		`- // libraries used by real code)`
`117`		`- mod.getFile().getAbsolutePath().matches("%/site-packages/%")`
`118`		`- or`
`119`		`- // for CI testing`
`120`		`- mod.getFile().getRelativePath().matches("%/find_subclass_test.py")`
	`115`	`+ // don't include anything found in site-packages`
	`116`	`+ exists(mod.getFile().getRelativePath())`
`121`	`117`	`}`
`122`	`118`
`123`	`119`	`predicate isTestCode(AstNode ast) {`