Skip to content

Commit c239a43

Browse files
committed
Changed Struts2ActionSupportClassFieldReadSource to be a FieldValueNode instead of a field read
1 parent 97a4230 commit c239a43

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

java/ql/lib/semmle/code/java/dataflow/FlowSources.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,10 @@ private class GuiceRequestParameterSource extends RemoteFlowSource {
143143
override string getSourceType() { result = "Guice request parameter" }
144144
}
145145

146-
private class Struts2ActionSupportClassFieldReadSource extends RemoteFlowSource {
147-
Struts2ActionSupportClassFieldReadSource() {
148-
exists(Struts2ActionSupportClass c |
149-
c.getASetterMethod().getField() = this.asExpr().(FieldRead).getField()
150-
)
146+
private class Struts2ActionSupportClassFieldSource extends RemoteFlowSource {
147+
Struts2ActionSupportClassFieldSource() {
148+
this.(DataFlow::FieldValueNode).getField() =
149+
any(Struts2ActionSupportClass c).getASetterMethod().getField()
151150
}
152151

153152
override string getSourceType() { result = "Struts2 ActionSupport field" }

0 commit comments

Comments
 (0)