Skip to content

Commit c68f9b0

Browse files
committed
C#: Address review comments.
1 parent 0fa2067 commit c68f9b0

File tree

1 file changed

+3
-1
lines changed
  • csharp/ql/lib/semmle/code/csharp/exprs

1 file changed

+3
-1
lines changed

csharp/ql/lib/semmle/code/csharp/exprs/Call.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ class Call extends DotNet::Call, Expr, @call {
7272

7373
pragma[noinline]
7474
private Expr getImplicitArgument(DotNet::Parameter p) {
75+
this.getTarget().getAParameter() = p and
7576
not exists(result.getExplicitArgumentName()) and
7677
(
7778
p.(Parameter).isParams() and
@@ -188,7 +189,7 @@ class Call extends DotNet::Call, Expr, @call {
188189
*/
189190
cached
190191
Expr getRuntimeArgumentForParameter(Parameter p) {
191-
p = this.getARuntimeTarget().getAParameter() and
192+
this.getARuntimeTarget().getAParameter() = p and
192193
(
193194
// Appears in the positional part of the call
194195
result = this.getImplicitRuntimeArgument(p)
@@ -200,6 +201,7 @@ class Call extends DotNet::Call, Expr, @call {
200201

201202
pragma[noinline]
202203
private Expr getImplicitRuntimeArgument(Parameter p) {
204+
this.getARuntimeTarget().getAParameter() = p and
203205
not exists(result.getExplicitArgumentName()) and
204206
(
205207
p.isParams() and

0 commit comments

Comments
 (0)