Skip to content

Commit c8f7304

Browse files
committed
C#: Address review comments.
1 parent e797b5c commit c8f7304

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

csharp/ql/src/Stubs/Stubs.qll

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ private string stubAccessibility(Member m) {
400400
if
401401
m.getDeclaringType() instanceof Interface
402402
or
403-
exists(useExplicitImplementedInterface(m))
403+
exists(getExplicitImplementedInterface(m))
404404
or
405405
m instanceof Constructor and m.isStatic()
406406
then result = ""
@@ -714,21 +714,21 @@ private string stubEventAccessors(Event e) {
714714
}
715715

716716
/**
717-
* Returns an interface that `c` explicitly implements, if either or the
718-
* following holds.
717+
* Returns an interface that `c` explicitly implements, if either of the
718+
* following also holds.
719719
* (1) `c` is not static.
720720
* (2) `c` is static and an implementation of a generic with type constraints.
721721
* (3) `c` is static and there is another member with the same name
722-
* but different return types.
722+
* but different return type.
723723
*
724-
* We use these rules, as explicit interfaces are needed in some cases, eg.
724+
* We use these rules as explicit interfaces are needed in some cases
725725
* for compilation purposes (both to distinguish members but also to ensure
726-
* type constraints are satisfied). We can't always use the explicit interface
727-
* due to the generic math support, because then in some cases we will only be
728-
* able to access a static via a type variable with type
726+
* type constraints are satisfied). We can't always use explicit interface
727+
* implementation due to the generic math support, because then in some cases
728+
* we will only be able to access a static via a type variable with type
729729
* constraints (C# 11 language feature).
730730
*/
731-
private Interface useExplicitImplementedInterface(Virtualizable c) {
731+
private Interface getExplicitImplementedInterface(Virtualizable c) {
732732
result = unique(Interface i | i = c.getExplicitlyImplementedInterface()) and
733733
(
734734
not c.isStatic()
@@ -754,8 +754,8 @@ private Interface useExplicitImplementedInterface(Virtualizable c) {
754754
}
755755

756756
private string stubExplicitImplementation(Member c) {
757-
if exists(useExplicitImplementedInterface(c))
758-
then result = stubClassName(useExplicitImplementedInterface(c)) + "."
757+
if exists(getExplicitImplementedInterface(c))
758+
then result = stubClassName(getExplicitImplementedInterface(c)) + "."
759759
else result = ""
760760
}
761761

0 commit comments

Comments
 (0)