Kotlin: exclude Kotlin files from java/underscore-identifier

tamasvajk · tamasvajk · commit d585839b7e76 · 2022-10-24T09:05:28.000+02:00
diff --git a/java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql b/java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql
@@ -22,7 +22,7 @@ class IdentifierElement extends Element {
 
 from IdentifierElement e, string msg
 where
-  e.fromSource() and
+  e.getCompilationUnit().isJavaSourceFile() and
   not e.(Constructor).isDefaultConstructor() and
   (
     e.getName() = "_" and
diff --git a/java/ql/test/kotlin/query-tests/UnderscoreIdentifier/UnderscoreIdentifier.expected b/java/ql/test/kotlin/query-tests/UnderscoreIdentifier/UnderscoreIdentifier.expected
@@ -1 +0,0 @@
-| Test.kt:8:14:8:25 | Exception _ | Use of underscore as a one-character identifier. |

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class IdentifierElement extends Element {`
`22`	`22`
`23`	`23`	`from IdentifierElement e, string msg`
`24`	`24`	`where`
`25`		`- e.fromSource() and`
	`25`	`+ e.getCompilationUnit().isJavaSourceFile() and`
`26`	`26`	`not e.(Constructor).isDefaultConstructor() and`
`27`	`27`	`(`
`28`	`28`	`e.getName() = "_" and`
Original file line number	Diff line number	Diff line change
`@@ -1 +0,0 @@`
`1`		`-\| Test.kt:8:14:8:25 \| Exception _ \| Use of underscore as a one-character identifier. \|`