Skip to content

Commit e0b5197

Browse files
committed
a slight refactor
1 parent 7f592a6 commit e0b5197

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

javascript/ql/lib/semmle/javascript/frameworks/DomEvents.qll

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,26 +37,22 @@ private DataFlow::SourceNode taintedEvent(DataFlow::TypeTracker t, string event)
3737
)
3838
or
3939
t.start() and
40-
exists(DataFlow::ParameterNode pn |
40+
exists(DataFlow::ParameterNode pn | result = pn |
4141
// https://developer.mozilla.org/en-US/docs/Web/API/ClipboardEvent
4242
pn.hasUnderlyingType("ClipboardEvent") and
43-
result = pn and
4443
event = "paste"
4544
or
4645
// https://developer.mozilla.org/en-US/docs/Web/API/DragEvent
4746
pn.hasUnderlyingType("DragEvent") and
48-
result = pn and
4947
event = "drop"
5048
or
5149
// https://developer.mozilla.org/en-US/docs/Web/API/InputEvent
5250
pn.hasUnderlyingType("InputEvent") and
53-
result = pn and
5451
event = "beforeinput"
5552
)
5653
or
5754
t.start() and
58-
exists(DataFlow::PropWrite pw | pw = DOM::domValueRef().getAPropertyWrite() |
59-
pw.getPropertyName() = "on" + event and
55+
exists(DataFlow::PropWrite pw | pw = DOM::domValueRef().getAPropertyWrite("on" + event) |
6056
event = ["paste", "drop"] and // doesn't work for beforeinput, it's just not part of the API
6157
result = pw.getRhs().getABoundFunctionValue(0).getParameter(0)
6258
)

0 commit comments

Comments
 (0)