Skip to content

Commit e50a0ee

Browse files
committed
Remove duplicate of expr exception propagation logic
1 parent 6f3bff1 commit e50a0ee

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

java/ql/lib/semmle/code/java/ControlFlowGraph.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -973,18 +973,14 @@ private module ControlFlowGraphImpl {
973973
// A pattern case statement can complete:
974974
// * On failure of its type test (boolean false)
975975
// * On failure of its guard test if any (boolean false)
976-
// * On any abrupt completion of its guard
977976
// * On completion of its variable declarations, if it is not a rule and has no guard (normal completion)
978977
// * On success of its guard test, if it is not a rule (boolean true)
979978
// (the latter two cases are accounted for by lastPatternCaseMatchingOp)
980979
exists(PatternCase pc | n = pc |
981980
last = pc and completion = basicBooleanCompletion(false)
982981
or
983982
last(pc.getGuard(), last, completion) and
984-
(
985-
completion = BooleanCompletion(false, _) or
986-
not completion instanceof NormalOrBooleanCompletion
987-
)
983+
completion = BooleanCompletion(false, _)
988984
or
989985
not pc.isRule() and
990986
lastPatternCaseMatchingOp(pc, last, completion)

0 commit comments

Comments
 (0)