Skip to content

Commit fe13137

Browse files
committed
Swift: Make default implementations private.
1 parent 439d919 commit fe13137

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

swift/ql/lib/codeql/swift/security/SqlInjectionExtensions.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class SqlInjectionAdditionalTaintStep extends Unit {
2828
/**
2929
* A default SQL injection sink for the sqlite3 C API.
3030
*/
31-
class CApiDefaultSqlInjectionSink extends SqlInjectionSink {
31+
private class CApiDefaultSqlInjectionSink extends SqlInjectionSink {
3232
CApiDefaultSqlInjectionSink() {
3333
// `sqlite3_exec` and variants of `sqlite3_prepare`.
3434
exists(CallExpr call |
@@ -48,7 +48,7 @@ class CApiDefaultSqlInjectionSink extends SqlInjectionSink {
4848
/**
4949
* A default SQL injection sink for the `SQLite.swift` library.
5050
*/
51-
class SQLiteSwiftDefaultSqlInjectionSink extends SqlInjectionSink {
51+
private class SQLiteSwiftDefaultSqlInjectionSink extends SqlInjectionSink {
5252
SQLiteSwiftDefaultSqlInjectionSink() {
5353
// Variants of `Connection.execute`, `connection.prepare` and `connection.scalar`.
5454
exists(CallExpr call |
@@ -70,7 +70,7 @@ class SQLiteSwiftDefaultSqlInjectionSink extends SqlInjectionSink {
7070
/**
7171
* A default SQL injection sink for the GRDB library.
7272
*/
73-
class GrdbDefaultSqlInjectionSink extends SqlInjectionSink {
73+
private class GrdbDefaultSqlInjectionSink extends SqlInjectionSink {
7474
GrdbDefaultSqlInjectionSink() {
7575
exists(CallExpr call, MethodDecl method |
7676
call.getStaticTarget() = method and

swift/ql/lib/codeql/swift/security/UnsafeJsEvalExtensions.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class UnsafeJsEvalAdditionalTaintStep extends Unit {
2828
/**
2929
* A default SQL injection sink for the `WKWebView` interface.
3030
*/
31-
class WKWebViewDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
31+
private class WKWebViewDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
3232
WKWebViewDefaultUnsafeJsEvalSink() {
3333
any(CallExpr ce |
3434
ce.getStaticTarget()
@@ -48,7 +48,7 @@ class WKWebViewDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
4848
/**
4949
* A default SQL injection sink for the `WKUserContentController` interface.
5050
*/
51-
class WKUserContentControllerDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
51+
private class WKUserContentControllerDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
5252
WKUserContentControllerDefaultUnsafeJsEvalSink() {
5353
any(CallExpr ce |
5454
ce.getStaticTarget()
@@ -61,7 +61,7 @@ class WKUserContentControllerDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
6161
/**
6262
* A default SQL injection sink for the `UIWebView` and `WebView` interfaces.
6363
*/
64-
class UIWebViewDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
64+
private class UIWebViewDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
6565
UIWebViewDefaultUnsafeJsEvalSink() {
6666
any(CallExpr ce |
6767
ce.getStaticTarget()
@@ -74,7 +74,7 @@ class UIWebViewDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
7474
/**
7575
* A default SQL injection sink for the `JSContext` interface.
7676
*/
77-
class JSContextDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
77+
private class JSContextDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
7878
JSContextDefaultUnsafeJsEvalSink() {
7979
any(CallExpr ce |
8080
ce.getStaticTarget()
@@ -87,7 +87,7 @@ class JSContextDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
8787
/**
8888
* A default SQL injection sink for the `JSEvaluateScript` function.
8989
*/
90-
class JSEvaluateScriptDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
90+
private class JSEvaluateScriptDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
9191
JSEvaluateScriptDefaultUnsafeJsEvalSink() {
9292
any(CallExpr ce |
9393
ce.getStaticTarget().(FreeFunctionDecl).hasName("JSEvaluateScript(_:_:_:_:_:_:)")
@@ -98,7 +98,7 @@ class JSEvaluateScriptDefaultUnsafeJsEvalSink extends UnsafeJsEvalSink {
9898
/**
9999
* A default SQL injection sanitrizer.
100100
*/
101-
class DefaultUnsafeJsEvalAdditionalTaintStep extends UnsafeJsEvalAdditionalTaintStep {
101+
private class DefaultUnsafeJsEvalAdditionalTaintStep extends UnsafeJsEvalAdditionalTaintStep {
102102
override predicate step(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
103103
exists(Argument arg |
104104
arg =

swift/ql/lib/codeql/swift/security/UnsafeWebViewFetchExtensions.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class UnsafeWebViewFetchAdditionalTaintStep extends Unit {
3434
* A default uncontrolled format string sink, such as certain arguments
3535
* to `UIWebView.loadHTMLString`.
3636
*/
37-
class UIKitWebKitWebViewFetchSink extends UnsafeWebViewFetchSink {
37+
private class UIKitWebKitWebViewFetchSink extends UnsafeWebViewFetchSink {
3838
Expr baseUrl;
3939

4040
UIKitWebKitWebViewFetchSink() {

0 commit comments

Comments
 (0)