miner: safely close payload when resolving best of many payloads

Ruteri · avalonche · commit 3c539c18ebe4 · 2023-03-22T18:14:36.000+11:00
diff --git a/miner/payload_building.go b/miner/payload_building.go
@@ -142,7 +142,13 @@ func (payload *Payload) resolveBestFullPayload(payloads []*Payload) {
 		}
 	}
 
-	close(payload.stop)
+	// Since we are not expecting any updates, close the payload already
+	select {
+	case <-payload.stop:
+	default:
+		close(payload.stop)
+	}
+
 	payload.cond.Broadcast() // fire signal for notifying full block
 
 	if payload.full != nil {

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,13 @@ func (payload Payload) resolveBestFullPayload(payloads []Payload) {`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`
`145`		`- close(payload.stop)`
	`145`	`+ // Since we are not expecting any updates, close the payload already`
	`146`	`+ select {`
	`147`	`+ case <-payload.stop:`
	`148`	`+ default:`
	`149`	`+ close(payload.stop)`
	`150`	`+ }`
	`151`	`+`
`146`	`152`	`payload.cond.Broadcast() // fire signal for notifying full block`
`147`	`153`
`148`	`154`	`if payload.full != nil {`