[Flang] Change sizeof argument name to "x" (llvm#130189)

This closes llvm#128610 by fixing the name of the argument to the sizeof
function to be "x" and adds a test.

Author: akuhlens

flang/lib/Evaluate/intrinsics.cpp

@@ -940,7 +940,7 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
             OptionalDIM, // unless array is assumed-size
             SizeDefaultKIND},
         KINDInt, Rank::scalar, IntrinsicClass::inquiryFunction},
-    {"sizeof", {{"a", AnyData, Rank::anyOrAssumedRank}}, SubscriptInt,
+    {"sizeof", {{"x", AnyData, Rank::anyOrAssumedRank}}, SubscriptInt,
         Rank::scalar, IntrinsicClass::inquiryFunction},
     {"spacing", {{"x", SameReal}}, SameReal},
     {"spread",

flang/test/Semantics/sizeof.f90

@@ -0,0 +1,10 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+  character(len=20) :: a, b
+  if (sizeof(a) == sizeof(x=b)) then
+    print *, "pass"
+  else
+    print *, "fail"
+  end if
+  !ERROR: unknown keyword argument to intrinsic 'sizeof'
+  print *, sizeof(a=a)
+end