Skip to content

Commit 68b7ab1

Browse files
ddubov100ddubov100
authored
[MLIR] Fully qualify entities in the ::mlir namespace in TilingInterface.td. (llvm#116765)
Adding mlir namespace to TilingInterface.td. Otherwise it can't be used with dialects not nested under the mlir namespace.
1 parent 61057b0 commit 68b7ab1

File tree

1 file changed

+43
-43
lines changed

1 file changed

+43
-43
lines changed

‎mlir/include/mlir/Interfaces/TilingInterface.td‎

Lines changed: 43 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def TilingInterface : OpInterface<"TilingInterface"> {
6666
/*desc=*/[{
6767
Returns a list of iterator types that describe the number of loops.
6868
}],
69-
/*retType=*/"SmallVector<utils::IteratorType>",
69+
/*retType=*/"::mlir::SmallVector<utils::IteratorType>",
7070
/*methodName=*/"getLoopIteratorTypes",
7171
/*args=*/(ins),
7272
/*methodBody=*/"",
@@ -77,9 +77,9 @@ def TilingInterface : OpInterface<"TilingInterface"> {
7777
Returns a list of ranges that describe the loop bounds and
7878
step for the loops of the operation.
7979
}],
80-
/*retTy=*/"SmallVector<Range>",
80+
/*retTy=*/"::mlir::SmallVector<::mlir::Range>",
8181
/*methodName=*/"getIterationDomain",
82-
/*args=*/(ins "OpBuilder &":$b),
82+
/*args=*/(ins "::mlir::OpBuilder &":$b),
8383
/*methodBody=*/"",
8484
/*defaultImplementation=*/"return {};"
8585
>,
@@ -104,12 +104,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
104104
untiled operation, a `Value` that is the result of the tiled
105105
operation.
106106
}],
107-
/*retType=*/"FailureOr<::mlir::TilingResult>",
107+
/*retType=*/"::mlir::FailureOr<::mlir::TilingResult>",
108108
/*methodName=*/"getTiledImplementation",
109109
/*args=*/(ins
110-
"OpBuilder &":$b,
111-
"ArrayRef<OpFoldResult> ":$offsets,
112-
"ArrayRef<OpFoldResult> ":$sizes),
110+
"::mlir::OpBuilder &":$b,
111+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
112+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes),
113113
/*methodBody=*/"",
114114
/*defaultImplementation=*/[{
115115
return {};
@@ -149,12 +149,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
149149
/*retType=*/"::llvm::LogicalResult",
150150
/*methodName=*/"getResultTilePosition",
151151
/*args=*/(ins
152-
"OpBuilder &":$b,
152+
"::mlir::OpBuilder &":$b,
153153
"unsigned":$resultNumber,
154-
"ArrayRef<OpFoldResult> ":$offsets,
155-
"ArrayRef<OpFoldResult> ":$sizes,
156-
"SmallVector<OpFoldResult> &":$resultOffsets,
157-
"SmallVector<OpFoldResult> &":$resultSizes),
154+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
155+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes,
156+
"::mlir::SmallVector<::mlir::OpFoldResult> &":$resultOffsets,
157+
"::mlir::SmallVector<::mlir::OpFoldResult> &":$resultSizes),
158158
/*methodBody=*/"",
159159
/*defaultImplementation=*/[{
160160
return failure();
@@ -187,13 +187,13 @@ def TilingInterface : OpInterface<"TilingInterface"> {
187187
used in the consumer to access). This is upto the caller to handle
188188
appropriately.
189189
}],
190-
/*retType=*/"FailureOr<::mlir::TilingResult>",
190+
/*retType=*/"::mlir::FailureOr<::mlir::TilingResult>",
191191
/*methodName=*/"generateResultTileValue",
192192
/*args=*/(ins
193-
"OpBuilder &":$b,
193+
"::mlir::OpBuilder &":$b,
194194
"unsigned":$resultNumber,
195-
"ArrayRef<OpFoldResult>":$offsets,
196-
"ArrayRef<OpFoldResult>":$sizes),
195+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$offsets,
196+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes),
197197
/*methodBody=*/"",
198198
/*defaultImplementation=*/[{
199199
return failure();
@@ -217,13 +217,13 @@ def TilingInterface : OpInterface<"TilingInterface"> {
217217
If it is illegal to fuse with a producer along the given operand for
218218
an operation, the implementation should return a failure.
219219
}],
220-
/*retType=*/"FailureOr<::mlir::TilingResult>",
220+
/*retType=*/"::mlir::FailureOr<::mlir::TilingResult>",
221221
/*methodName=*/"getTiledImplementationFromOperandTile",
222222
/*args=*/(ins
223-
"OpBuilder &":$b,
223+
"::mlir::OpBuilder &":$b,
224224
"unsigned":$operandNumber,
225-
"ArrayRef<OpFoldResult>":$offsets,
226-
"ArrayRef<OpFoldResult>":$sizes),
225+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$offsets,
226+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes),
227227
/*methodBody=*/"",
228228
/*defaultImplementation=*/[{
229229
return failure();
@@ -292,12 +292,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
292292
/*retType=*/"::llvm::LogicalResult",
293293
/*methodName=*/"getIterationDomainTileFromOperandTile",
294294
/*args=*/(ins
295-
"OpBuilder &":$b,
295+
"::mlir::OpBuilder &":$b,
296296
"unsigned":$operandNumber,
297-
"ArrayRef<OpFoldResult> ":$offsets,
298-
"ArrayRef<OpFoldResult> ":$sizes,
299-
"SmallVectorImpl<OpFoldResult> &":$iterDomainOffsets,
300-
"SmallVectorImpl<OpFoldResult> &":$iterDomainSizes),
297+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
298+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes,
299+
"::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainOffsets,
300+
"::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainSizes),
301301
/*methodBody=*/"",
302302
/*defaultImplementation=*/[{
303303
return failure();
@@ -327,12 +327,12 @@ def TilingInterface : OpInterface<"TilingInterface"> {
327327
/*retType=*/"::llvm::LogicalResult",
328328
/*methodName=*/"getIterationDomainTileFromResultTile",
329329
/*args=*/(ins
330-
"OpBuilder &":$b,
330+
"::mlir::OpBuilder &":$b,
331331
"unsigned":$resultNumber,
332-
"ArrayRef<OpFoldResult> ":$offsets,
333-
"ArrayRef<OpFoldResult> ":$sizes,
334-
"SmallVectorImpl<OpFoldResult> &":$iterDomainOffsets,
335-
"SmallVectorImpl<OpFoldResult> &":$iterDomainSizes),
332+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$offsets,
333+
"::mlir::ArrayRef<::mlir::OpFoldResult> ":$sizes,
334+
"::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainOffsets,
335+
"::mlir::SmallVectorImpl<::mlir::OpFoldResult> &":$iterDomainSizes),
336336
/*methodBody=*/"",
337337
/*defaultImplementation=*/[{
338338
return failure();
@@ -352,7 +352,7 @@ def TilingInterface : OpInterface<"TilingInterface"> {
352352
/*retType=*/"::llvm::LogicalResult",
353353
/*methodName=*/"generateScalarImplementation",
354354
/*args=*/(ins
355-
"OpBuilder &":$b,
355+
"::mlir::OpBuilder &":$b,
356356
"Location ":$loc,
357357
"ValueRange ":$ivs),
358358
/*methodBody=*/"",
@@ -377,13 +377,13 @@ def PartialReductionOpInterface : OpInterface<"PartialReductionOpInterface"> {
377377
operation reduction. The tensor shape is equal to operation result
378378
shape with new dimension for each non zero tile size.
379379
}],
380-
/*retType=*/"FailureOr<SmallVector<Value>>",
380+
/*retType=*/"::mlir::FailureOr<SmallVector<Value>>",
381381
/*methodName=*/"generateInitialTensorForPartialReduction",
382382
/*args=*/(ins
383-
"OpBuilder &":$b,
383+
"::mlir::OpBuilder &":$b,
384384
"Location":$loc,
385-
"ArrayRef<OpFoldResult>":$sizes,
386-
"ArrayRef<int>":$reductionDim),
385+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes,
386+
"::mlir::ArrayRef<int>":$reductionDim),
387387
/*methodBody=*/"",
388388
/*defaultImplementation=*/[{
389389
return failure();
@@ -396,15 +396,15 @@ def PartialReductionOpInterface : OpInterface<"PartialReductionOpInterface"> {
396396
less or equal to the tile size. This is meant to be used with
397397
`mergeReductions` method which will combine the partial reductions.
398398
}],
399-
/*retType=*/"FailureOr<TilingResult>",
399+
/*retType=*/"::mlir::FailureOr<TilingResult>",
400400
/*methodName=*/"tileToPartialReduction",
401401
/*args=*/(ins
402-
"OpBuilder &":$b,
402+
"::mlir::OpBuilder &":$b,
403403
"Location ":$loc,
404404
"ValueRange":$init,
405-
"ArrayRef<OpFoldResult>":$offsets,
406-
"ArrayRef<OpFoldResult>":$sizes,
407-
"ArrayRef<int>":$reductionDims),
405+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$offsets,
406+
"::mlir::ArrayRef<::mlir::OpFoldResult>":$sizes,
407+
"::mlir::ArrayRef<int>":$reductionDims),
408408
/*methodBody=*/"",
409409
/*defaultImplementation=*/[{
410410
return failure();
@@ -416,13 +416,13 @@ def PartialReductionOpInterface : OpInterface<"PartialReductionOpInterface"> {
416416
tiled along the reduction dimensions. This will only apply the
417417
reduction the operation.
418418
}],
419-
/*retType=*/"FailureOr<MergeResult>",
419+
/*retType=*/"::mlir::FailureOr<MergeResult>",
420420
/*methodName=*/"mergeReductions",
421421
/*args=*/(ins
422-
"OpBuilder &":$b,
422+
"::mlir::OpBuilder &":$b,
423423
"Location ":$loc,
424424
"ValueRange":$partialReduce,
425-
"ArrayRef<int>":$reductionDim),
425+
"::mlir::ArrayRef<int>":$reductionDim),
426426
/*methodBody=*/"",
427427
/*defaultImplementation=*/[{
428428
return failure();

0 commit comments

Comments
 (0)