Skip to content

Commit 6d52efc

Browse files
[Github] Error on HTTP 4xx Errors (llvm#168919)
When downloading bazelisk/buildifier, we use curl, which still returns exit code zero on HTTP 4xx errors unless we pass --fail. This patch adds --fail flags so that error messages are more clear.
1 parent e79c7c1 commit 6d52efc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/bazel-checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
2626
- name: Setup Buildifier
2727
run: |
28-
sudo curl -L https://github.com/bazelbuild/buildtools/releases/download/v8.2.1/buildifier-linux-amd64 -o /usr/bin/buildifier
28+
sudo curl -L https://github.com/bazelbuild/buildtools/releases/download/v8.2.1/buildifier-linux-amd64 -o /usr/bin/buildifier --fail
2929
sudo chmod +x /usr/bin/buildifier
3030
- name: Run Buildifier
3131
run: |
@@ -49,7 +49,7 @@ jobs:
4949
run: |
5050
sudo apt-get update
5151
sudo apt-get install -y libmpfr-dev libpfm4-dev m4 libedit-dev
52-
sudo curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-amd64.deb > /tmp/bazelisk.deb
52+
sudo curl -L https://github.com/bazelbuild/bazelisk/releases/download/v1.27.0/bazelisk-amd64.deb --fail > /tmp/bazelisk.deb
5353
sudo apt-get install -y /tmp/bazelisk.deb
5454
rm /tmp/bazelisk.deb
5555
- name: Build/Test

0 commit comments

Comments
 (0)