Skip to content

Commit f5eb5e9

Browse files
removed superfluous session invocation
1 parent 55eb1c1 commit f5eb5e9

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

boto3_refresh_session/session.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
from attrs import define, field
2424
from attrs.validators import ge, instance_of, optional
25-
from boto3 import Session
25+
from boto3 import Session, client
2626
from botocore.credentials import (
2727
DeferredRefreshableCredentials,
2828
RefreshableCredentials,
@@ -115,7 +115,9 @@ def __attrs_post_init__(self):
115115
)
116116

117117
__session._credentials = __credentials
118-
self.session = Session(botocore_session=__session)
118+
self.session = Session(
119+
botocore_session=__session, **self.session_kwargs
120+
)
119121

120122
def _get_credentials(self) -> dict:
121123
"""Returns temporary credentials via AWS STS.
@@ -126,11 +128,10 @@ def _get_credentials(self) -> dict:
126128
AWS temporary credentials.
127129
"""
128130

129-
__session = Session(region_name=self.region, **self.session_kwargs)
130-
__client = __session.client(
131+
__sts_client = client(
131132
service_name="sts", region_name=self.region, **self.client_kwargs
132133
)
133-
__temporary_credentials = __client.assume_role(
134+
__temporary_credentials = __sts_client.assume_role(
134135
RoleArn=self.role_arn,
135136
RoleSessionName=self.session_name,
136137
DurationSeconds=self.ttl,

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "boto3-refresh-session"
3-
version = "0.0.25"
3+
version = "0.0.26"
44
description = "A simple Python package for refreshing boto3 sessions automatically."
55
authors = [
66
{name = "Mike Letts",email = "[email protected]"}

tests/test_session.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ def test_defer_refresh():
1616
defer_refresh=True,
1717
).session
1818
s3 = session.client(service_name="s3")
19+
s3.list_buckets()
1920

2021
# testing defer_refresh = False
2122
logger.info("Testing AutoRefreshableSession with defer_refresh = False")
@@ -26,3 +27,4 @@ def test_defer_refresh():
2627
defer_refresh=False,
2728
).session
2829
s3 = session.client(service_name="s3")
30+
s3.list_buckets()

0 commit comments

Comments
 (0)