Skip to content

Commit 991e59c

Browse files
authored
ci: Turn off title validation for single commit PRs (Unity-Technologies#3313)
<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> When the semantic commit action was added into the branch, the default squash commit for a pr with only a single commit was the commit name and not the PR title. Since then, Github has [added a feature to allow configuration of the default](https://github.com/orgs/community/discussions/16271) and we have that setting set in our repo. This PR turns off the validation of commits as the check is not valid anymore.
1 parent 48fb70a commit 991e59c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/conventional-pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Conventional PR
22

3-
# Controls when the action will run.
3+
# Controls when the action will run.
44
on:
55
pull_request:
66
branches:
@@ -17,7 +17,7 @@ jobs:
1717
steps:
1818
- name: semantic-pull-request
1919
# Internal Unity mirror available at jesseo/action-semantic-pull-request, but actions from private repos aren't supported, so continue to use the public one below
20-
uses: amannn/action-semantic-pull-request@b7a9a97cb10fa6e1ae02647e718798175f6b1f1d
20+
uses: amannn/action-semantic-pull-request@v5
2121
env:
2222
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2323
with:
@@ -34,4 +34,4 @@ jobs:
3434
# For work-in-progress PRs you can typically use draft pull requests from Github. However, private repositories on the free plan don't have this option and therefore this action allows you to opt-in to using the special '[WIP]' prefix to indicate this state. This will avoid the validation of the PR title and the pull request checks remain pending. Note that a second check will be reported if this is enabled.
3535
#wip: # optional
3636
# When using "Squash and merge" on a PR with only one commit, GitHub will suggest using that commit message instead of the PR title for the merge commit, and it's easy to commit this by mistake. Enable this option to also validate the commit message for one commit PRs.
37-
validateSingleCommit: true # optional
37+
# validateSingleCommit: true # optional

0 commit comments

Comments
 (0)