fix: Make error handling of missing adapter return error exit code

Author: relekang

package.json

@@ -51,6 +51,7 @@
     "babel-polyfill": "^6.20.0",
     "babel-preset-node6": "^11.0.0",
     "jest": "^19.0.2",
+    "micro-analytics-adapter-memory": "^0.1.0",
     "nodemon": "^1.11.0",
     "request-promise": "^4.1.1"
   }

src/index.js

@@ -3,22 +3,26 @@ const micro = require('micro')
 const parseArgs = require('./parseArgs')
 const db = require('./db');
 
-const flags = parseArgs(process.argv)
+try {
+  const flags = parseArgs(process.argv)
 
-db.initDbAdapter(flags)
+  db.initDbAdapter(flags)
 
-const handler = require('./handler')
-const server = micro(handler)
+  const handler = require('./handler')
+  const server = micro(handler)
 
-server.listen(flags.port, flags.host, (error) => {
-  if (error) {
-    console.error(error)
-    process.exit(1)
-  }
-
-  console.log(
-    'micro-analytics listening on ' + flags.host + ':' + flags.port + '\n' +
-    '  with adapter ' + flags.adapter +
-    (db.hasFeature("subscribe") ? '\n  with server side events' : '')
-  )
-})
+  server.listen(flags.port, flags.host, (error) => {
+    if (error) {
+      console.error(error)
+      process.exit(1)
+    }
+    console.log(
+      'micro-analytics listening on ' + flags.host + ':' + flags.port + '\n' +
+      '  with adapter ' + flags.adapter +
+      (db.hasFeature("subscribe") ? '\n  with server side events' : '')
+    )
+  })
+} catch (error) {
+  console.error(error.message)
+  process.exit(1)
+}

src/parseArgs.js

@@ -27,11 +27,7 @@ module.exports = function parseArgs(argv) {
     }
   } catch (err) {
     if (err.code === 'MODULE_NOT_FOUND') {
-      if (process.env.NODE_ENV !== 'test') {
-      // Console.error a warning message, but normally exit the process to avoid printing ugly npm ERR lines and stack trace.
-      console.error(`\n${repeatCharacter(' ', 22)}⚠️ ERROR ⚠️\n${repeatCharacter('-', 55)}\nYou specified "${adapterName}" as the DB_ADAPTER, but no package\ncalled "micro-analytics-adapter-${adapterName}" was found.\n\nPlease make sure you spelled the name correctly and\nhave "npm install"ed the necessary adapter package!\n${repeatCharacter('-', 55)}\n`)
-      process.exit(0)
-      }
+      throw new Error(`\n${repeatCharacter(' ', 22)}⚠️ ERROR ⚠️\n${repeatCharacter('-', 55)}\nYou specified "${adapterName}" as the DB_ADAPTER, but no package\ncalled "micro-analytics-adapter-${adapterName}" was found.\n\nPlease make sure you spelled the name correctly and\nhave "npm install"ed the necessary adapter package!\n${repeatCharacter('-', 55)}\n`)
     } else {
       throw err
     }

tests/__snapshots__/parseArgs.test.js.snap

@@ -12,3 +12,16 @@ Object {
   "port": 3000,
 }
 `;
+
+exports[`parseArgs should throw on non existing adapter 1`] = `
+"
+                      ⚠️ ERROR ⚠️
+-------------------------------------------------------
+You specified \\"not-a-real-adapter\\" as the DB_ADAPTER, but no package
+called \\"micro-analytics-adapter-not-a-real-adapter\\" was found.
+
+Please make sure you spelled the name correctly and
+have \\"npm install\\"ed the necessary adapter package!
+-------------------------------------------------------
+"
+`;

tests/parseArgs.test.js

@@ -6,9 +6,15 @@ describe('parseArgs', () => {
     expect(parseArgs(['node', 'micro-analytics'])).toMatchSnapshot();
   })
 
+  it('should throw on non existing adapter', () => {
+    expect(() => {
+      parseArgs(['node', 'micro-analytics', '-a', 'not-a-real-adapter'])
+    }).toThrowErrorMatchingSnapshot()
+  });
+
   it("should use DB_ADAPTER environment variable as default if set", () => {
-    process.env.DB_ADAPTER = 'redis'
-    expect(parseArgs(['node', 'micro-analytics']).adapter).toEqual('redis');
+    process.env.DB_ADAPTER = 'memory'
+    expect(parseArgs(['node', 'micro-analytics']).adapter).toEqual('memory');
     delete process.env.DB_ADAPTER
   })
 

yarn.lock

@@ -1836,6 +1836,10 @@ micro-analytics-adapter-flat-file-db@^1.2.1:
     then-flat-file-db "^1.0.0"
     zen-observable "^0.4.0"
 
+micro-analytics-adapter-memory@^0.1.0:
+  version "0.1.0"
+  resolved "https://registry.yarnpkg.com/micro-analytics-adapter-memory/-/micro-analytics-adapter-memory-0.1.0.tgz#c8bcdb5e4e46be156d610be73931ab9a7456f329"
+
 [email protected]:
   version "6.1.0"
   resolved "https://registry.yarnpkg.com/micro/-/micro-6.1.0.tgz#c933e1dd90dea56b0517b62b2af00d3f5351d79d"