Add ability to filter ?all requests

Author: mxstbr

README.md

@@ -44,7 +44,7 @@ This is how you'd track pageviews for a website: (though note that this can be u
 
 If you just want to get the views for an id and don't want to increment the views during a `GET` request, set `inc` to `false` in your query parameter. (`/x?inc=false`)
 
-If you want to get all views for all ids, set the `all` query parameter to `true`. (`/?all=true`)
+If you want to get all views for all ids, set the `all` query parameter to `true`. (`/?all=true`) If you pass the `all` parameter to an id, all ids starting with that pathname will be included. (e.g. `/x?all=true` will match views for `/x`, `/xyz` but not `/y`)
 
 ## Built with
 

src/index.js

@@ -7,12 +7,12 @@ const { pushView } = require('./utils')
 module.exports = async function (req, res) {
   const { pathname, query } = url.parse(req.url, /* parseQueryString */ true)
   // Send all views down if "?all" is true
-  if (query.all === 'true' || query.all === true) {
+  if (String(query.all) === 'true') {
     const data = {
       data: {},
       time: Date.now()
     }
-    for (let key of db.keys()) {
+    for (let key of db.keys().filter(key => String(query.filter) === 'false' ? true : key.startsWith(pathname))) {
       data.data[key] = db.get(key)
     }
     send(res, 200, data)
@@ -25,7 +25,7 @@ module.exports = async function (req, res) {
   if (req.method !== 'GET' && req.method !== 'POST') {
     throw createError(400, 'Please make a GET or a POST request.')
   }
-  const shouldIncrement = query.inc !== 'false' && query.inc !== false
+  const shouldIncrement = String(query.inc) !== 'false'
   try {
     const currentViews = db.has(pathname) ? db.get(pathname).views.length : 0
     // Add a view and send the total views back to the client

tests/items.test.js

@@ -68,4 +68,27 @@ describe('all', () => {
     expect(body.data['/route2'].views).toBeDefined()
     expect(body.data['/route2'].views.length).toBe(3)
   })
+
+  describe('filtering', () => {
+    it('should filter based on pathname', async () => {
+      await request(`${url}/rover`)
+      await request(`${url}/route`)
+      const body = JSON.parse(await request(`${url}/rover?all=true`))
+      expect(Object.keys(body.data).length).toBe(1)
+      expect(body.data['/rover'].views).toBeDefined()
+      expect(body.data['/rover'].views.length).toBe(1)
+    })
+
+    it('should filter based on starting with pathname', async () => {
+      await request(`${url}/rover`)
+      await request(`${url}/rover2`)
+      await request(`${url}/route`)
+      const body = JSON.parse(await request(`${url}/rover?all=true`))
+      expect(Object.keys(body.data).length).toBe(2)
+      expect(body.data['/rover'].views).toBeDefined()
+      expect(body.data['/rover'].views.length).toBe(1)
+      expect(body.data['/rover2'].views).toBeDefined()
+      expect(body.data['/rover2'].views.length).toBe(1)
+    })
+  })
 })