Skip redefining MICROBIT_BLE_SECURITY_MODE when MICROBIT_BLE_OPEN = 1 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnVidler could you add this to your backlog for after the MakeCode 2022 work? |
|
@JohnVidler I can't add this to the CODAL project as it's not in the lancaster org, could you make sure you add it to your backlog? |
|
@finneyj this is currently causing breakage as people try to move back to MakeCode/Python with the iOS or Android app after using ML tool (ml.microbit.org/thenextgen). Could we please review and fix to go into the next MakeCode release? |
|
It adds a second This avoids redefining MICROBIT_BLE_SECURITY_MODE after the MICROBIT_BLE_OPEN == 1 block defines it. It makes the code match MicroBitConfig.h. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.