Projects - continue using downloads folder on Android 10

Author: martinwork

app/build.gradle

@@ -6,7 +6,8 @@ android {
         applicationId "com.samsung.microbit"
         minSdkVersion 21
         targetSdk 33
-        // Once target SDK version is 30, requestLegacyExternalStorage will no longer work
+        // When target SDK version is 30+,
+        // requestLegacyExternalStorage will continue to work for 29 Android 10
     }
     buildTypes {
         release {

app/src/main/AndroidManifest.xml

@@ -22,8 +22,8 @@
     <uses-permission android:name="android.permission.INTERNET"/>
     <uses-permission android:name="android.permission.BLUETOOTH" android:maxSdkVersion="30" />
     <uses-permission android:name="android.permission.BLUETOOTH_ADMIN" android:maxSdkVersion="30"/>
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="29" />
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="29" />
     <uses-permission android:name="android.permission.VIBRATE"/>
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
     <uses-permission android:name="android.permission.INTERACT_ACROSS_USERS"  android:protectionLevel="signature"/>
@@ -60,7 +60,7 @@
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:theme="@style/AppTheme.NoActionBar"
-        android:requestLegacyExternalStorage="false">
+        android:requestLegacyExternalStorage="true">
 
         <activity
             android:name=".ui.activity.HomeActivity"

app/src/main/java/com/samsung/microbit/ui/activity/HomeActivity.java

@@ -501,9 +501,12 @@ private void setFirstRun300( boolean yes) {
      * flash on a micro:bit board.
      */
     private void installSamples( boolean withThanks) {
-        if(isFirstRun() || isFirstRun300() && !ProjectsHelper.legacyStorage()) {
-            setFirstRun(false);
-            setFirstRun300(false);
+        boolean firstRun    = isFirstRun();
+        boolean firstRun300 = isFirstRun300();
+        if ( firstRun) setFirstRun(false);
+        if ( firstRun300) setFirstRun300(false);
+
+        if( firstRun || firstRun300 && !ProjectsHelper.legacyStorage()) {
             //First Run. Install the Sample applications
             if ( withThanks) {
                 new Thread(new Runnable() {
@@ -516,7 +519,6 @@ public void run() {
                                 PopUp.TYPE_ALERT,
                                 null, null);
                         ProjectsHelper.installSamples(MBApp.getApp().getBaseContext());
-
                     }
                 }).start();
             } else {

app/src/main/java/com/samsung/microbit/utils/ProjectsHelper.java

@@ -58,7 +58,7 @@ public static String prefsGetString(String name, String def) {
     }
 
     public static boolean legacyStorage() {
-        return Build.VERSION.SDK_INT <= Build.VERSION_CODES.P;
+        return Build.VERSION.SDK_INT <= Build.VERSION_CODES.Q;
     }
 
     public static File getDownloadsDirectory() {