Skip to content

Commit ef0403e

Browse files
upy-fs-hex: Convert importFilesFromIntelHex optional args into optional obj.
1 parent 070c865 commit ef0403e

File tree

3 files changed

+23
-23
lines changed

3 files changed

+23
-23
lines changed

src/__tests__/micropython-fs-builder.spec.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,11 @@ describe('Writing files to the filesystem.', () => {
148148
const shortData = shortMap.get(0x3c900);
149149

150150
it('Add files to hex.', () => {
151-
const filesObj: { [filename: string]: Uint8Array } = {};
152-
filesObj[files[0].fileName] = strToBytes(files[0].fileStr);
153-
filesObj[files[1].fileName] = strToBytes(files[1].fileStr);
154-
155151
testResetFileSystem();
156-
const fwWithFsOther = addIntelHexFiles(uPyHexFile, filesObj);
152+
const fwWithFsOther = addIntelHexFiles(uPyHexFile, {
153+
[files[0].fileName]: strToBytes(files[0].fileStr),
154+
[files[1].fileName]: strToBytes(files[1].fileStr),
155+
});
157156
// fs.writeFileSync('./ignore/output2.hex', fwWithFsOther);
158157

159158
const opMap = MemoryMap.fromHex(fwWithFsOther);

src/__tests__/micropython-fs-hex.spec.ts

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,9 @@ describe('Test importing files from hex.', () => {
444444
micropythonFs.write('a.py', originalFileContent);
445445

446446
const failCase = () => {
447-
micropythonFs.importFilesFromIntelHex(hexStrWithFiles, false);
447+
micropythonFs.importFilesFromIntelHex(hexStrWithFiles, {
448+
overwrite: false,
449+
});
448450
};
449451

450452
expect(failCase).toThrow(Error);
@@ -456,7 +458,7 @@ describe('Test importing files from hex.', () => {
456458
const originalFileContent = 'Original file content.';
457459
micropythonFs.write('a.py', originalFileContent);
458460

459-
micropythonFs.importFilesFromIntelHex(hexStrWithFiles, true);
461+
micropythonFs.importFilesFromIntelHex(hexStrWithFiles, { overwrite: true });
460462

461463
expect(micropythonFs.read('a.py')).not.toEqual(originalFileContent);
462464
expect(micropythonFs.read('a.py')).toEqual(extraFiles['a.py']);
@@ -493,11 +495,10 @@ describe('Test importing files from hex.', () => {
493495
const micropythonFs = new MicropythonFsHex(uPyHexFile);
494496
micropythonFs.write('old_file.py', 'Some content.');
495497

496-
const fileList = micropythonFs.importFilesFromIntelHex(
497-
hexStrWithFiles,
498-
false,
499-
true
500-
);
498+
const fileList = micropythonFs.importFilesFromIntelHex(hexStrWithFiles, {
499+
overwrite: false,
500+
formatFirst: true,
501+
});
501502

502503
Object.keys(extraFiles).forEach((filename) => {
503504
expect(fileList).toContain(filename);
@@ -510,15 +511,13 @@ describe('Test importing files from hex.', () => {
510511
const micropythonFs = new MicropythonFsHex(uPyHexFile);
511512
micropythonFs.write('old_file.py', 'Some content.');
512513

513-
const fileList1 = micropythonFs.importFilesFromIntelHex(
514-
hexStrWithFiles,
515-
false
516-
);
517-
const fileList2 = micropythonFs.importFilesFromIntelHex(
518-
hexStrWithFiles,
519-
true,
520-
false
521-
);
514+
const fileList1 = micropythonFs.importFilesFromIntelHex(hexStrWithFiles, {
515+
overwrite: false,
516+
});
517+
const fileList2 = micropythonFs.importFilesFromIntelHex(hexStrWithFiles, {
518+
overwrite: true,
519+
formatFirst: false,
520+
});
522521

523522
Object.keys(extraFiles).forEach((filename) => {
524523
expect(fileList1).toContain(filename);

src/micropython-fs-hex.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,10 @@ export class MicropythonFsHex implements FsInterface {
217217
*/
218218
importFilesFromIntelHex(
219219
intelHex: string,
220-
overwrite?: boolean,
221-
formatFirst?: boolean
220+
{
221+
overwrite = false,
222+
formatFirst = false,
223+
}: { overwrite?: boolean; formatFirst?: boolean } = {}
222224
): string[] {
223225
const files = getIntelHexFiles(intelHex);
224226
if (formatFirst) {

0 commit comments

Comments
 (0)