Skip to content

Commit 7d89a95

Browse files
Update delete recording label to include action (#539)
1 parent 22afeae commit 7d89a95

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

lang/ui.en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@
468468
"description": "Confirmation dialog text"
469469
},
470470
"delete-recording-aria": {
471-
"defaultMessage": "Delete recording {sample} of {numSamples}",
471+
"defaultMessage": "Delete recording {sample} of {numSamples} for action \"{action}\"",
472472
"description": "Aria label for data sample delete action"
473473
},
474474
"disconnect-action": {

src/components/ActionDataSamplesCard.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ const ActionDataSamplesCard = ({
8484
{
8585
sample: value.recordings.length - idx,
8686
numSamples: value.recordings.length,
87+
action: value.name,
8788
}
8889
)}
8990
position="absolute"
@@ -100,6 +101,7 @@ const ActionDataSamplesCard = ({
100101
recording={recording}
101102
numRecordings={value.recordings.length}
102103
actionId={value.ID}
104+
actionName={value.name}
103105
recordingIndex={idx}
104106
isNew={newRecordingId === recording.ID}
105107
onNewAnimationEnd={clearNewRecordingId}
@@ -133,6 +135,7 @@ const ActionDataSamplesCard = ({
133135
<DataSample
134136
key={recording.ID}
135137
actionId={value.ID}
138+
actionName={value.name}
136139
recordingIndex={idx}
137140
recording={recording}
138141
numRecordings={value.recordings.length}
@@ -288,6 +291,7 @@ const DataSample = ({
288291
recording,
289292
numRecordings,
290293
actionId,
294+
actionName,
291295
recordingIndex,
292296
isNew,
293297
onNewAnimationEnd,
@@ -298,6 +302,7 @@ const DataSample = ({
298302
recording: RecordingData;
299303
numRecordings: number;
300304
actionId: number;
305+
actionName: string;
301306
recordingIndex: number;
302307
isNew: boolean;
303308
onNewAnimationEnd?: () => void;
@@ -331,6 +336,7 @@ const DataSample = ({
331336
{
332337
sample: numRecordings - recordingIndex,
333338
numSamples: numRecordings,
339+
action: actionName,
334340
}
335341
)}
336342
onClick={handleDelete}

src/messages/ui.en.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -815,6 +815,18 @@
815815
{
816816
"type": 1,
817817
"value": "numSamples"
818+
},
819+
{
820+
"type": 0,
821+
"value": " for action \""
822+
},
823+
{
824+
"type": 1,
825+
"value": "action"
826+
},
827+
{
828+
"type": 0,
829+
"value": "\""
818830
}
819831
],
820832
"disconnect-action": [

0 commit comments

Comments
 (0)