Skip to content

Commit a98069c

Browse files
Tweak the deployment path to include a 'v/' (#242)
Don't prefix deployments
1 parent 0570b78 commit a98069c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/pr-url.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ jobs:
88
steps:
99
- uses: microbit-foundation/[email protected]
1010
with:
11-
uri-template: 'https://review-ml.microbit.org/{branch}/prototype/'
11+
uri-template: 'https://review-ml.microbit.org/{branch}'
1212
repo-token: ${{ secrets.GITHUB_TOKEN }}

deployment.cjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ const { s3Config } = createDeploymentDetailsFromOptions({
2121
module.exports = {
2222
deploymentDir: './dist',
2323
...s3Config,
24-
// We deploy to a fixed path for the nextgen version
25-
bucketPrefix: posixPath.join(s3Config.bucketPrefix || '', 'prototype'),
24+
// For non-review versions deploy to the prototype URL
25+
bucketPrefix: s3Config.bucketPrefix ?? 'v/prototype',
2626
region: 'eu-west-1',
2727
removeNonexistentObjects: true,
2828
enableS3StaticWebsiteHosting: true,

0 commit comments

Comments
 (0)