Skip to content

Commit 537a8f5

Browse files
Add unknown to translatable strings for sim extension
1 parent 7c8f74a commit 537a8f5

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

simx/lang/ui.en.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,9 @@
22
"select-label": {
33
"defaultMessage": "ML event:",
44
"description": "Label for the simulator event select input"
5+
},
6+
"unknown-event-label": {
7+
"defaultMessage": "unknown",
8+
"description": "Label the default ML event"
59
}
610
}

simx/src/Simulator.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* SPDX-License-Identifier: MIT
55
*/
66
import { ChangeEvent, useCallback, useEffect, useRef, useState } from "react";
7-
import { FormattedMessage } from "react-intl";
7+
import { FormattedMessage, useIntl } from "react-intl";
88
import "./simulator.css";
99

1010
type MessageType = "register" | "data" | "request_data" | "simulate_event";
@@ -20,11 +20,15 @@ interface EventData {
2020
}
2121

2222
const simChannel = "microbit-foundation/pxt-microbit-ml";
23-
const defaultEvent: EventData = { name: "unknown", value: 1 };
2423
const textDecoder = new TextDecoder();
2524
const textEncoder = new TextEncoder();
2625

2726
const Simulator = () => {
27+
const intl = useIntl();
28+
const defaultEvent: EventData = {
29+
name: intl.formatMessage({ id: "unknown-event-label" }),
30+
value: 1,
31+
};
2832
const [events, setEvents] = useState<EventData[]>([defaultEvent]);
2933
const [selectedEvent, setSelectedEvent] = useState<number>(
3034
defaultEvent.value

simx/src/messages/ui.en.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,11 @@
44
"type": 0,
55
"value": "ML event:"
66
}
7+
],
8+
"unknown-event-label": [
9+
{
10+
"type": 0,
11+
"value": "unknown"
12+
}
713
]
814
}

0 commit comments

Comments
 (0)