fix: check isSimpleReporter to be sure of full block field (RaspberryPiFoundation#206)

isFullBlockField be true in scenarios where it is not the only field and so
needs visiting. This happens at least for MakeCode if block dummy input
clickable image fields (add remove icons).

Author: microbit-matt-hillsdon

src/line_cursor.ts

@@ -245,9 +245,14 @@ export class LineCursor extends Marker {
         return true;
       case ASTNode.types.INPUT:
         return !(location as Blockly.Connection).isConnected();
-      case ASTNode.types.FIELD:
-        // @ts-expect-error isFullBlockField is a protected method.
-        return !(location as Blockly.Field).isFullBlockField();
+      case ASTNode.types.FIELD: {
+        const field = node.getLocation() as Blockly.Field;
+        return !(
+          field.getSourceBlock()?.isSimpleReporter() &&
+          // @ts-expect-error isFullBlockField is a protected method.
+          field.isFullBlockField()
+        );
+      }
       default:
         return false;
     }

src/navigation.ts

@@ -1456,12 +1456,14 @@ function fakeEventForNode(node: Blockly.ASTNode): PointerEvent {
  * @returns True if we showed the editor, false otherwise.
  */
 function tryShowFullBlockFieldEditor(block: Blockly.Block): boolean {
-  for (const input of block.inputList) {
-    for (const field of input.fieldRow) {
-      // @ts-expect-error isFullBlockField is a protected method.
-      if (field.isClickable() && field.isFullBlockField()) {
-        field.showEditor();
-        return true;
+  if (block.isSimpleReporter()) {
+    for (const input of block.inputList) {
+      for (const field of input.fieldRow) {
+        // @ts-expect-error isFullBlockField is a protected method.
+        if (field.isClickable() && field.isFullBlockField()) {
+          field.showEditor();
+          return true;
+        }
       }
     }
   }