Skip to content

Commit 6ea48de

Browse files
committed
refactor: Makes var names more specific, changing element to elRef
1 parent 3d7daeb commit 6ea48de

File tree

7 files changed

+18
-19
lines changed

7 files changed

+18
-19
lines changed

src/components/useClickAway/stories/useClickAway.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ Vue function that triggers a callback when the user clicks outside of the target
66

77
```typescript
88
useClickAway(
9-
element: Ref<null | Element>,
9+
elRef: Ref<null | Element>,
1010
onClickAway: (e: Event) => void,
1111
events?: string[]
1212
): void;
1313
```
1414

1515
### Parameters
1616

17-
- `element: string` the element to check for click away events
17+
- `elRef: string` the element to check for click away events
1818
- `onClickAway: string` the callback to run when triggering a click away
1919
- `events: string` list of events to listen to, defaults to `['mousedown', 'touchstart']`
2020

src/components/useClickAway/useClickAway.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import { onMounted, onUnmounted, Ref } from '../../api'
33
const defaultEvents = ['mousedown', 'touchstart']
44

55
export function useClickAway(
6-
element: Ref<null | Element>,
6+
elRef: Ref<null | Element>,
77
onClickAway: (e: Event) => void,
88
events = defaultEvents
99
) {
1010
const handler = (e: Event) => {
11-
if (element.value && !element.value.contains(e.target as Node)) {
11+
if (elRef.value && !elRef.value.contains(e.target as Node)) {
1212
onClickAway(e)
1313
}
1414
}

src/components/useHover/stories/useHover.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ Vue function that tracks mouse hover state of a given element.
55
## Reference
66

77
```typescript
8-
useHover(element: Ref<null | Element>): Ref<boolean>
8+
useHover(elRef: Ref<null | Element>): Ref<boolean>
99
```
1010

1111
### Parameters
1212

13-
- `element: Ref<null | Element>` the element used for tracking the mouse hover state
13+
- `elRef: Ref<null | Element>` the element used for tracking the mouse hover state
1414

1515
### Returns
1616

src/components/useHover/useHover.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { mount } from '../../helpers/test'
22
import { ref } from '../../api'
33
import { useHover } from '../../vue-use-kit'
44

5-
const elementContainer: any = { ref: { value: null } }
65
const testComponent = () => ({
76
template: `
87
<div id="isHovered" v-if="isHovered"></div>

src/components/useHover/useHover.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ref, onMounted, onUnmounted, Ref } from '../../api'
22

3-
export function useHover(element: Ref<null | Element>) {
3+
export function useHover(elRef: Ref<null | Element>) {
44
const isHovered = ref(false)
55

66
const mouseEnterHandler = () => {
@@ -12,15 +12,15 @@ export function useHover(element: Ref<null | Element>) {
1212
}
1313

1414
onMounted(() => {
15-
if (!element.value) return
16-
element.value.addEventListener('mouseenter', mouseEnterHandler)
17-
element.value.addEventListener('mouseleave', mouseLeaveHandler)
15+
if (!elRef.value) return
16+
elRef.value.addEventListener('mouseenter', mouseEnterHandler)
17+
elRef.value.addEventListener('mouseleave', mouseLeaveHandler)
1818
})
1919

2020
onUnmounted(() => {
21-
if (!element.value) return
22-
element.value.removeEventListener('mouseenter', mouseEnterHandler)
23-
element.value.removeEventListener('mouseleave', mouseLeaveHandler)
21+
if (!elRef.value) return
22+
elRef.value.removeEventListener('mouseenter', mouseEnterHandler)
23+
elRef.value.removeEventListener('mouseleave', mouseLeaveHandler)
2424
})
2525

2626
return isHovered

src/components/useMouseElement/stories/useMouseElement.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ and optionally tracks the mouse position relative to a given element.
66
## Reference
77

88
```typescript
9-
useMouseElement(element: Ref<null | Element>): {
9+
useMouseElement(elRef: Ref<null | Element>): {
1010
docX: Ref<number>;
1111
docY: Ref<number>;
1212
elX: Ref<number>;
@@ -20,7 +20,7 @@ useMouseElement(element: Ref<null | Element>): {
2020

2121
### Parameters
2222

23-
- `element: Ref<null | Element>` used for getting the `x` and `y` mouse position relative to the position of the given element
23+
- `elRef: Ref<null | Element>` used for getting the `x` and `y` mouse position relative to the position of the given element
2424

2525
### Returns
2626

src/components/useMouseElement/useMouseElement.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ref, onMounted, onUnmounted, Ref } from '../../api'
22

3-
export function useMouseElement(element: Ref<null | Element>) {
3+
export function useMouseElement(elRef: Ref<null | Element>) {
44
const docX = ref(0)
55
const docY = ref(0)
66
const elX = ref(0)
@@ -11,10 +11,10 @@ export function useMouseElement(element: Ref<null | Element>) {
1111
const elInfoH = ref(0)
1212

1313
const mouseMoveHandler = (e: MouseEvent) => {
14-
if (!element.value) return
14+
if (!elRef.value) return
1515
docX.value = e.pageX
1616
docY.value = e.pageY
17-
const { left, top, height, width } = element.value.getBoundingClientRect()
17+
const { left, top, height, width } = elRef.value.getBoundingClientRect()
1818
elInfoX.value = left + window.pageXOffset
1919
elInfoY.value = top + window.pageYOffset
2020
elInfoW.value = width

0 commit comments

Comments
 (0)